OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i965: Remove two_side_color from brw_compute_vue_map().

Browse Source 
Since we now lay out the VUE the same way regardless of whether
two-sided color is enabled, brw_compute_vue_map() no longer needs to
know whether two-sided color is enabled.  This allows the two-sided
color flag to be removed from the clip, GS, and VS keys, so that fewer
GPU programs need to be recompiled when turning two-sided color on and
off.

Reviewed-by: Eric Anholt <eric@anholt.net>
This commit is contained in:
Paul Berry
2011-09-03 08:42:28 -07:00
parent f2b09257ba
commit becd54eedb
12 changed files with 11 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mesa/drivers/dri/i965/brw_clip.c
View File

@@ -69,8 +69,7 @@ static void compile_clip_prog( struct brw_context *brw,
c.func.single_program_flow = 1;
c.key = *key;
brw_compute_vue_map(&c.vue_map, intel, c.key.nr_userclip,
c.key.do_twoside_color, c.key.attrs);
brw_compute_vue_map(&c.vue_map, intel, c.key.nr_userclip, c.key.attrs);
/* nr_regs is the number of registers filled by reading data from the VUE.
* This program accesses the entire VUE, so nr_regs needs to be the size of
@@ -150,7 +149,6 @@ static void upload_clip_prog(struct brw_context *brw)
/* _NEW_LIGHT */
key.do_flat_shading = (ctx->Light.ShadeModel == GL_FLAT);
key.pv_first = (ctx->Light.ProvokingVertex == GL_FIRST_VERTEX_CONVENTION);
key.do_twoside_color = (ctx->Light.Enabled && ctx->Light.Model.TwoSide);
/* _NEW_TRANSFORM */
key.nr_userclip = brw_count_bits(ctx->Transform.ClipPlanesEnabled);

3
src/mesa/drivers/dri/i965/brw_clip.h
View File

@@ -55,8 +55,7 @@ struct brw_clip_prog_key {
GLuint copy_bfc_cw:1;
GLuint copy_bfc_ccw:1;
GLuint clip_mode:3;
GLuint do_twoside_color:1;
GLuint pad0:10;
GLuint pad0:11;
GLfloat offset_factor;
GLfloat offset_units;

2
src/mesa/drivers/dri/i965/brw_context.h
View File

@@ -967,7 +967,7 @@ int brw_disasm (FILE *file, struct brw_instruction *inst, int gen);
/* brw_vs.c */
void brw_compute_vue_map(struct brw_vue_map *vue_map,
const struct intel_context *intel, int nr_userclip,
bool two_side_color, GLbitfield64 outputs_written);
GLbitfield64 outputs_written);
/*======================================================================
* Inline conversion functions. These are better-typed than the

4
src/mesa/drivers/dri/i965/brw_gs.c
View File

@@ -64,8 +64,7 @@ static void compile_gs_prog( struct brw_context *brw,
c.key = *key;
/* The geometry shader needs to access the entire VUE. */
struct brw_vue_map vue_map;
brw_compute_vue_map(&vue_map, intel, c.key.nr_userclip,
c.key.do_twoside_color, c.key.attrs);
brw_compute_vue_map(&vue_map, intel, c.key.nr_userclip, c.key.attrs);
c.nr_regs = (vue_map.num_slots + 1)/2;
mem_ctx = NULL;
@@ -152,7 +151,6 @@ static void populate_key( struct brw_context *brw,
/* _NEW_LIGHT */
key->pv_first = (ctx->Light.ProvokingVertex == GL_FIRST_VERTEX_CONVENTION);
key->do_twoside_color = (ctx->Light.Enabled && ctx->Light.Model.TwoSide);
if (key->primitive == GL_QUADS && ctx->Light.ShadeModel != GL_FLAT) {
/* Provide consistent primitive order with brw_set_prim's
* optimization of single quads to trifans.

3
src/mesa/drivers/dri/i965/brw_gs.h
View File

@@ -45,8 +45,7 @@ struct brw_gs_prog_key {
GLuint pv_first:1;
GLuint need_gs_prog:1;
GLuint nr_userclip:4;
GLuint do_twoside_color:1;
GLuint pad:21;
GLuint pad:22;
};
struct brw_gs_compile {

3
src/mesa/drivers/dri/i965/brw_sf.c
View File

@@ -63,8 +63,7 @@ static void compile_sf_prog( struct brw_context *brw,
brw_init_compile(brw, &c.func, mem_ctx);
c.key = *key;
brw_compute_vue_map(&c.vue_map, intel, c.key.nr_userclip,
c.key.do_twoside_color, c.key.attrs);
brw_compute_vue_map(&c.vue_map, intel, c.key.nr_userclip, c.key.attrs);
c.urb_entry_read_offset = brw_sf_compute_urb_entry_read_offset(intel);
c.nr_attr_regs = (c.vue_map.num_slots + 1)/2 - c.urb_entry_read_offset;
c.nr_setup_regs = c.nr_attr_regs;

2
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
View File

@@ -1906,7 +1906,7 @@ vec4_visitor::emit_urb_writes()
/* FINISHME: edgeflag */
brw_compute_vue_map(&c->vue_map, intel, c->key.nr_userclip,
c->key.two_side_color, c->prog_data.outputs_written);
c->prog_data.outputs_written);
/* First mrf is the g0-based message header containing URB handles and such,
* which is implied in VS_OPCODE_URB_WRITE.

3
src/mesa/drivers/dri/i965/brw_vs.c
View File

@@ -56,7 +56,7 @@ static inline void assign_vue_slot(struct brw_vue_map *vue_map,
void
brw_compute_vue_map(struct brw_vue_map *vue_map,
const struct intel_context *intel, int nr_userclip,
bool two_side_color, GLbitfield64 outputs_written)
GLbitfield64 outputs_written)
{
int i;
@@ -258,7 +258,6 @@ static void brw_upload_vs_prog(struct brw_context *brw)
key.nr_userclip = brw_count_bits(ctx->Transform.ClipPlanesEnabled);
key.copy_edgeflag = (ctx->Polygon.FrontMode != GL_FILL ||
ctx->Polygon.BackMode != GL_FILL);
key.two_side_color = (ctx->Light.Enabled && ctx->Light.Model.TwoSide);
/* _NEW_LIGHT | _NEW_BUFFERS */
key.clamp_vertex_color = ctx->Light._ClampVertexColor;

1
src/mesa/drivers/dri/i965/brw_vs.h
View File

@@ -48,7 +48,6 @@ struct brw_vs_prog_key {
GLuint nr_userclip:4;
GLuint copy_edgeflag:1;
GLuint point_coord_replace:8;
GLuint two_side_color: 1;
GLuint clamp_vertex_color:1;
};

2
src/mesa/drivers/dri/i965/brw_vs_emit.c
View File

@@ -326,7 +326,7 @@ static void brw_vs_alloc_regs( struct brw_vs_compile *c )
/* Allocate outputs. The non-position outputs go straight into message regs.
*/
brw_compute_vue_map(&c->vue_map, intel, c->key.nr_userclip,
c->key.two_side_color, c->prog_data.outputs_written);
c->prog_data.outputs_written);
c->first_output = reg;
first_reladdr_output = get_first_reladdr_output(&c->vp->program);

3
src/mesa/drivers/dri/i965/gen6_sf_state.c
View File

@@ -127,8 +127,7 @@ upload_sf_state(struct brw_context *brw)
urb_entry_read_offset = 1;
nr_userclip = brw_count_bits(ctx->Transform.ClipPlanesEnabled);
brw_compute_vue_map(&vue_map, intel, nr_userclip, two_side_color,
vs_outputs_written);
brw_compute_vue_map(&vue_map, intel, nr_userclip, vs_outputs_written);
urb_entry_read_length = (vue_map.num_slots + 1)/2 - urb_entry_read_offset;
if (urb_entry_read_length == 0) {
/* Setting the URB entry read length to 0 causes undefined behavior, so

3
src/mesa/drivers/dri/i965/gen7_sf_state.c
View File

@@ -50,8 +50,7 @@ upload_sbe_state(struct brw_context *brw)
int two_side_color = (ctx->Light.Enabled && ctx->Light.Model.TwoSide);
uint16_t attr_overrides[FRAG_ATTRIB_MAX];
brw_compute_vue_map(&vue_map, intel, nr_userclip, two_side_color,
vs_outputs_written);
brw_compute_vue_map(&vue_map, intel, nr_userclip, vs_outputs_written);
urb_entry_read_length = (vue_map.num_slots + 1)/2 - urb_entry_read_offset;
if (urb_entry_read_length == 0) {
/* Setting the URB entry read length to 0 causes undefined behavior, so