OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pipebuffer: Temporarily allow simultaneous CPU writes.

Browse Source 
Also, fast path for re-fencing the same buffer multiple times with the same fence.
This commit is contained in:
José Fonseca
2008-04-22 19:47:02 +09:00
parent 57987ea673
commit b4b3a73bdf
1 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/gallium/auxiliary/pipebuffer/pb_buffer_fenced.c
View File

@@ -215,15 +215,21 @@ fenced_buffer_serialize(struct fenced_buffer *fenced_buf, unsigned flags)
struct fenced_buffer_list *fenced_list = fenced_buf->list; struct fenced_buffer_list *fenced_list = fenced_buf->list;
struct pipe_winsys *winsys = fenced_list->winsys; struct pipe_winsys *winsys = fenced_list->winsys;
/* Allow concurrent reads */
if(((fenced_buf->flags | flags) & PIPE_BUFFER_USAGE_WRITE) == 0) if(((fenced_buf->flags | flags) & PIPE_BUFFER_USAGE_WRITE) == 0)
return PIPE_OK; return PIPE_OK;
/* Wait for the CPU to finish */
if(fenced_buf->mapcount) { if(fenced_buf->mapcount) {
/* FIXME */ /* FIXME: Use thread conditions variables to signal when mapcount
* reaches zero */
debug_warning("attemp to write concurrently to buffer"); debug_warning("attemp to write concurrently to buffer");
/* XXX: we must not fail here in order to support texture mipmap generation
return PIPE_ERROR_RETRY; return PIPE_ERROR_RETRY;
*/
} }
/* Wait for the GPU to finish */
if(fenced_buf->fence) { if(fenced_buf->fence) {
if(winsys->fence_finish(winsys, fenced_buf->fence, 0) != 0) if(winsys->fence_finish(winsys, fenced_buf->fence, 0) != 0)
return PIPE_ERROR_RETRY; return PIPE_ERROR_RETRY;
@@ -353,6 +359,16 @@ buffer_fence(struct pb_buffer *buf,
/* FIXME: receive this as a parameter */ /* FIXME: receive this as a parameter */
unsigned flags = fence ? PIPE_BUFFER_USAGE_GPU_READ_WRITE : 0; unsigned flags = fence ? PIPE_BUFFER_USAGE_GPU_READ_WRITE : 0;
if(fence == fenced_buf->fence) {
/* Handle the same fence case specially, not only because it is a fast
* path, but mostly to avoid serializing two writes with the same fence,
* as that would bring the hardware down to synchronous operation without
* any benefit.
*/
fenced_buf->flags |= flags & PIPE_BUFFER_USAGE_GPU_READ_WRITE;
return;
}
if(fenced_buffer_serialize(fenced_buf, flags) != PIPE_OK) { if(fenced_buffer_serialize(fenced_buf, flags) != PIPE_OK) {
/* FIXME: propagate error */ /* FIXME: propagate error */
(void)0; (void)0;