OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glsl: fix incorrect optimisation in opt_constant_variable()

Browse Source 
When handling function inputs the optimisation pass incorrectly
assumes the inputs are undefined. Here we simply change things to
assume inputs have always been assigned a value. Any further
optimisations will be taken care of once function inlining takes
place.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2984
Fixes: 65122e9e80 ("ir_constant_variable: New pass to mark constant-assigned variables constant.")

Reviewed-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5413>
This commit is contained in:
Timothy Arceri
2020-06-10 15:19:22 +10:00
committed by Marge Bot
parent 07aefe8065
commit b33f811068
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/compiler/glsl/opt_constant_variable.cpp
View File

@@ -165,6 +165,15 @@ ir_constant_variable_visitor::visit_enter(ir_call *ir)
entry = get_assignment_entry(var, this->ht);
entry->assignment_count++;
}
/* We don't know if the variable passed to this function has been
* assigned a value or if it is undefined, so for now we always assume
* it has been assigned a value. Once functions have been inlined any
* further potential optimisations will be taken care of.
*/
struct assignment_entry *entry;
entry = get_assignment_entry(param, this->ht);
entry->assignment_count++;
}
/* Mark the return storage as having been assigned to */