From b2ee2de1fb4980a28cc83cff504b0736d4e383bd Mon Sep 17 00:00:00 2001
From: Adam Jackson <ajax@redhat.com>
Date: Tue, 20 Sep 2022 13:51:00 -0400
Subject: [PATCH] egl: Untangle some spaghetti around _eglLookupDisplay

Only eglapi needs any of this.

Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18713>
---
 src/egl/main/eglapi.c     | 21 +++++++++++++++++++++
 src/egl/main/egldisplay.c | 20 --------------------
 src/egl/main/egldisplay.h | 18 ------------------
 3 files changed, 21 insertions(+), 38 deletions(-)

diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index 5e3360ee844..1da7de0fc25 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
@@ -272,6 +272,27 @@ _eglCheckSync(_EGLDisplay *disp, _EGLSync *s, const char *msg)
 }
 
 
+/**
+ * Lookup a handle to find the linked display.
+ * Return NULL if the handle has no corresponding linked display.
+ */
+static _EGLDisplay *
+_eglLookupDisplay(EGLDisplay dpy)
+{
+   simple_mtx_lock(_eglGlobal.Mutex);
+
+   _EGLDisplay *cur = _eglGlobal.DisplayList;
+   while (cur) {
+      if (cur == (_EGLDisplay *) dpy)
+         break;
+      cur = cur->Next;
+   }
+   simple_mtx_unlock(_eglGlobal.Mutex);
+
+   return cur;
+}
+
+
 /**
  * Lookup and lock a display.
  */
diff --git a/src/egl/main/egldisplay.c b/src/egl/main/egldisplay.c
index 9d49ec55dad..39850e34f7c 100644
--- a/src/egl/main/egldisplay.c
+++ b/src/egl/main/egldisplay.c
@@ -374,26 +374,6 @@ _eglCleanupDisplay(_EGLDisplay *disp)
 }
 
 
-/**
- * Return EGL_TRUE if the given handle is a valid handle to a display.
- */
-EGLBoolean
-_eglCheckDisplayHandle(EGLDisplay dpy)
-{
-   _EGLDisplay *cur;
-
-   simple_mtx_lock(_eglGlobal.Mutex);
-   cur = _eglGlobal.DisplayList;
-   while (cur) {
-      if (cur == (_EGLDisplay *) dpy)
-         break;
-      cur = cur->Next;
-   }
-   simple_mtx_unlock(_eglGlobal.Mutex);
-   return (cur != NULL);
-}
-
-
 /**
  * Return EGL_TRUE if the given resource is valid.  That is, the display does
  * own the resource.
diff --git a/src/egl/main/egldisplay.h b/src/egl/main/egldisplay.h
index 532b2a9bc5d..205466955f3 100644
--- a/src/egl/main/egldisplay.h
+++ b/src/egl/main/egldisplay.h
@@ -254,28 +254,10 @@ extern void
 _eglCleanupDisplay(_EGLDisplay *disp);
 
 
-extern EGLBoolean
-_eglCheckDisplayHandle(EGLDisplay dpy);
-
-
 extern EGLBoolean
 _eglCheckResource(void *res, _EGLResourceType type, _EGLDisplay *disp);
 
 
-/**
- * Lookup a handle to find the linked display.
- * Return NULL if the handle has no corresponding linked display.
- */
-static inline _EGLDisplay *
-_eglLookupDisplay(EGLDisplay dpy)
-{
-   _EGLDisplay *disp = (_EGLDisplay *) dpy;
-   if (!_eglCheckDisplayHandle(dpy))
-      disp = NULL;
-   return disp;
-}
-
-
 /**
  * Return the handle of a linked display, or EGL_NO_DISPLAY.
  */