OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bin/gen_release_notes.py: html escape all external data

Browse Source 
All of these (bug titles, patch titles, features, and people's names)
can contain characters that are not valid html. Just escape everything
for safety.

Fixes: 86079447da
       ("scripts: Add a gen_release_notes.py script")
Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
This commit is contained in:
Dylan Baker
2019-10-23 08:50:40 -07:00
parent 7e4b87f987
commit b153785370
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
bin/gen_release_notes.py
View File

@@ -38,6 +38,9 @@ CURRENT_GL_VERSION = '4.6'
CURRENT_VK_VERSION = '1.1'
TEMPLATE = Template(textwrap.dedent("""\
<%!
import html
%>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html lang="en">
<head>
@@ -89,7 +92,7 @@ TEMPLATE = Template(textwrap.dedent("""\
<ul>
%for f in features:
<li>${f}</li>
<li>${html.escape(f)}</li>
%endfor
</ul>
@@ -97,7 +100,7 @@ TEMPLATE = Template(textwrap.dedent("""\
<ul>
%for b in bugs:
<li>${b}</li>
<li>${html.escape(b)}</li>
%endfor
</ul>
@@ -106,9 +109,9 @@ TEMPLATE = Template(textwrap.dedent("""\
<ul>
%for c, author in changes:
%if author:
<p>${c}</p>
<p>${html.escape(c)}</p>
%else:
<li>${c}</li>
<li>${html.escape(c)}</li>
%endif
%endfor
</ul>