iris: Drop redundant iris_address::write flag.
The write flag is redundant since it can be inferred easily from the iris_address::access domain. This allows the iris_address struct to be laid out more efficiently in memory, leading to a measurable improvement in several Piglit Drawoverhead test-cases. Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3875>
This commit is contained in:

committed by
Marge Bot

parent
eb5d1c2722
commit
ae88e79f69
@@ -52,7 +52,8 @@ __gen_combine_address(struct iris_batch *batch, void *location,
|
||||
uint64_t result = addr.offset + delta;
|
||||
|
||||
if (addr.bo) {
|
||||
iris_use_pinned_bo(batch, addr.bo, addr.write, addr.access);
|
||||
iris_use_pinned_bo(batch, addr.bo,
|
||||
!iris_domain_is_read_only(addr.access), addr.access);
|
||||
/* Assume this is a general address, not relative to a base. */
|
||||
result += addr.bo->gtt_offset;
|
||||
}
|
||||
@@ -129,5 +130,5 @@ UNUSED static struct iris_address
|
||||
rw_bo(struct iris_bo *bo, uint64_t offset, enum iris_domain access)
|
||||
{
|
||||
return (struct iris_address) { .bo = bo, .offset = offset,
|
||||
.write = true, .access = access };
|
||||
.access = access };
|
||||
}
|
||||
|
Reference in New Issue
Block a user