OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mesa: remove unnecessary NewState flagging for glPopAttrib(GL_ENABLE_BIT)

Browse Source 
pop_enable_group calls _mesa_set_enable for every state it changes,
so we don't need do anything else.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8850>
This commit is contained in:
Marek Olšák
2021-01-31 23:10:26 -05:00
committed by Marge Bot
parent 5acc115bd8
commit a9299a9b5e
1 changed files with 1 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/mesa/main/attrib.c
View File

@@ -919,41 +919,8 @@ _mesa_PopAttrib(void)
}
}
if (mask & GL_ENABLE_BIT) {
if (mask & GL_ENABLE_BIT)
pop_enable_group(ctx, &attr->Enable);
ctx->NewState |= _NEW_COLOR |
_NEW_DEPTH |
_NEW_FOG |
_NEW_LIGHT |
_NEW_LINE |
_NEW_POINT |
_NEW_POLYGON |
_NEW_SCISSOR |
_NEW_TRANSFORM |
_NEW_TEXTURE_STATE |
_NEW_BUFFERS |
_NEW_MULTISAMPLE |
_NEW_PROGRAM |
_NEW_FRAG_CLAMP;
ctx->NewDriverState |= ctx->DriverFlags.NewAlphaTest |
ctx->DriverFlags.NewBlend |
ctx->DriverFlags.NewClipPlaneEnable |
ctx->DriverFlags.NewDepth |
ctx->DriverFlags.NewDepthClamp |
ctx->DriverFlags.NewFragClamp |
ctx->DriverFlags.NewFramebufferSRGB |
ctx->DriverFlags.NewLineState |
ctx->DriverFlags.NewLogicOp |
ctx->DriverFlags.NewMultisampleEnable |
ctx->DriverFlags.NewPolygonState |
ctx->DriverFlags.NewSampleAlphaToXEnable |
ctx->DriverFlags.NewSampleMask |
ctx->DriverFlags.NewSampleShading |
ctx->DriverFlags.NewScissorTest |
ctx->DriverFlags.NewStencil |
ctx->DriverFlags.NewNvConservativeRasterization |
ctx->DriverFlags.NewTileRasterOrder;
}
if (mask & GL_EVAL_BIT) {
memcpy(&ctx->Eval, &attr->Eval, sizeof(struct gl_eval_attrib));