OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glsl: drop the dce of global vars from GLSL IR linker

Browse Source 
All this does is compilcate things such as forcing us to set
var->data.always_active_io in the glsl linker. Just let NIR clean
these up for us instead.

A Zink test hits a new assert but this is not a regression it just
uncovers an existing mesa bug.

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22846>
This commit is contained in:
Timothy Arceri
2023-04-05 12:30:24 +10:00
committed by Marge Bot
parent a8c485efee
commit a8534c7b4c
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/compiler/glsl/glsl_parser_extras.cpp
View File

@@ -2442,10 +2442,7 @@ do_common_optimization(exec_list *ir, bool linked,
if (options->OptimizeForAOS && !linked) if (options->OptimizeForAOS && !linked)
OPT(opt_flip_matrices, ir); OPT(opt_flip_matrices, ir);
if (linked) OPT(do_dead_code_unlinked, ir);
OPT(do_dead_code, ir);
else
OPT(do_dead_code_unlinked, ir);
OPT(do_dead_code_local, ir); OPT(do_dead_code_local, ir);
OPT(do_tree_grafting, ir); OPT(do_tree_grafting, ir);
OPT(do_minmax_prune, ir); OPT(do_minmax_prune, ir);

3
src/gallium/drivers/zink/ci/zink-radv-vangogh-fails.txt
View File

@@ -21,6 +21,9 @@ spec@arb_query_buffer_object@qbo@query-GL_GEOMETRY_SHADER_INVOCATIONS-SYNC-GL_UN
glx@glx-multi-window-single-context,Crash glx@glx-multi-window-single-context,Crash
spec@egl_chromium_sync_control@conformance@eglGetSyncValuesCHROMIUM_ust_test,Fail spec@egl_chromium_sync_control@conformance@eglGetSyncValuesCHROMIUM_ust_test,Fail
# Mesa bug not Zink bug. See piglit MR 824
spec@arb_bindless_texture@compiler@images@return-struct.frag,Crash
# #6115 # #6115
spec@arb_tessellation_shader@execution@variable-indexing@tes-both-input-array-float-index-rd,Crash spec@arb_tessellation_shader@execution@variable-indexing@tes-both-input-array-float-index-rd,Crash
spec@arb_tessellation_shader@execution@variable-indexing@tes-both-input-array-vec2-index-rd,Crash spec@arb_tessellation_shader@execution@variable-indexing@tes-both-input-array-vec2-index-rd,Crash