OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel/blorp: Stop setting 3DSTATE_DRAWING_RECTANGLE

Browse Source 
The Vulkan driver sets 3DSTATE_DRAWING_RECTANGLE once to MAX_INT x MAX_INT
at the GPU initialization time and never sets it again.  The GL driver sets
it every time the framebuffer changes.  Originally, blorp set it to the
size of the drawing area but meant we had to set it back in the Vulkan
driver.  Instead, we can easily just do that in the GL driver's blorp_exec
implementation and not set it in blorp core.

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
This commit is contained in:
Jason Ekstrand
2016-09-12 15:50:05 -07:00
committed by Jason Ekstrand
parent b56f509ee0
commit a814e18c96
3 changed files with 5 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/intel/blorp/blorp_genX_exec.h
View File

@@ -1216,11 +1216,6 @@ blorp_exec(struct blorp_batch *batch, const struct blorp_params *params)
clear.DepthClearValue = params->depth.clear_color.u32[0]; clear.DepthClearValue = params->depth.clear_color.u32[0];
} }
blorp_emit(batch, GENX(3DSTATE_DRAWING_RECTANGLE), rect) {
rect.ClippedDrawingRectangleXMax = MAX2(params->x1, params->x0) - 1;
rect.ClippedDrawingRectangleYMax = MAX2(params->y1, params->y0) - 1;
}
blorp_emit(batch, GENX(3DPRIMITIVE), prim) { blorp_emit(batch, GENX(3DPRIMITIVE), prim) {
prim.VertexAccessType = SEQUENTIAL; prim.VertexAccessType = SEQUENTIAL;
prim.PrimitiveTopologyType = _3DPRIM_RECTLIST; prim.PrimitiveTopologyType = _3DPRIM_RECTLIST;

15
src/intel/vulkan/genX_blorp_exec.c
View File

@@ -203,21 +203,6 @@ genX(blorp_exec)(struct blorp_batch *batch,
blorp_exec(batch, params); blorp_exec(batch, params);
/* BLORP sets DRAWING_RECTANGLE but we always want it set to the maximum.
* Since we set it once at driver init and never again, we have to set it
* back after invoking blorp.
*
* TODO: BLORP should assume a max drawing rectangle
*/
blorp_emit(batch, GENX(3DSTATE_DRAWING_RECTANGLE), rect) {
rect.ClippedDrawingRectangleYMin = 0;
rect.ClippedDrawingRectangleXMin = 0;
rect.ClippedDrawingRectangleYMax = UINT16_MAX;
rect.ClippedDrawingRectangleXMax = UINT16_MAX;
rect.DrawingRectangleOriginY = 0;
rect.DrawingRectangleOriginX = 0;
}
cmd_buffer->state.vb_dirty = ~0; cmd_buffer->state.vb_dirty = ~0;
cmd_buffer->state.dirty = ~0; cmd_buffer->state.dirty = ~0;
cmd_buffer->state.push_constants_dirty = ~0; cmd_buffer->state.push_constants_dirty = ~0;

5
src/mesa/drivers/dri/i965/genX_blorp_exec.c
View File

@@ -206,6 +206,11 @@ retry:
brw_emit_depth_stall_flushes(brw); brw_emit_depth_stall_flushes(brw);
blorp_emit(batch, GENX(3DSTATE_DRAWING_RECTANGLE), rect) {
rect.ClippedDrawingRectangleXMax = MAX2(params->x1, params->x0) - 1;
rect.ClippedDrawingRectangleYMax = MAX2(params->y1, params->y0) - 1;
}
blorp_exec(batch, params); blorp_exec(batch, params);
/* Make sure we didn't wrap the batch unintentionally, and make sure we /* Make sure we didn't wrap the batch unintentionally, and make sure we