From a5c3c452b812ed7b8225017d4ff420089ac404af Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Wed, 8 Jan 2025 07:50:44 -0500 Subject: [PATCH] mesa: use default params for clearbuffer functions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit this might otherwise pull in user-specified params from the unpack buffer and access arbitrary data cc: mesa-stable Reviewed-by: Marek Olšák Part-of: --- src/mesa/main/bufferobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 30b8b2196ae..bf405b2513f 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -995,10 +995,11 @@ convert_clear_buffer_data(struct gl_context *ctx, const GLvoid *data, const char *caller) { GLenum internalformatBase = _mesa_get_format_base_format(internalformat); + struct gl_pixelstore_attrib packing = {.Alignment = 1}; if (_mesa_texstore(ctx, 1, internalformatBase, internalformat, 0, &clearValue, 1, 1, 1, - format, type, data, &ctx->Unpack)) { + format, type, data, &packing)) { return true; } else {