OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

anv: Remove block promoting non CPU mapped bos to coherent

Browse Source 
The intention of this block was to set one of the flags that is used
to select a PAT index but this was doing more than that.
It was promoting WB+0 way coherency BOs to WC+1 way coherency possibly
causing regression in platforms without LLC.

anv_device_get_pat_entry() return WC/writecombining if no flags is
set so we don't need this block after all.

Reported-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com>
Fixes: a65e982b44 ("anv: Split ANV_BO_ALLOC_HOST_CACHED_COHERENT into two actual flags")
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29769>
This commit is contained in:
José Roberto de Souza
2024-06-18 07:34:15 -07:00
committed by Marge Bot
parent 5f27c4cc4e
commit 9d8d5cf8c9
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/intel/vulkan/anv_allocator.c
View File

@@ -1575,12 +1575,6 @@ anv_device_alloc_bo(struct anv_device *device,
assert((alloc_flags & ANV_BO_ALLOC_MAPPED) == 0 ||
(alloc_flags & (ANV_BO_ALLOC_HOST_CACHED | ANV_BO_ALLOC_HOST_COHERENT)));
/* KMD requires a valid PAT index, so setting HOST_COHERENT/WC to bos that
* don't need CPU access
*/
if ((alloc_flags & ANV_BO_ALLOC_MAPPED) == 0)
alloc_flags |= ANV_BO_ALLOC_HOST_COHERENT;
/* In platforms with LLC we can promote all bos to cached+coherent for free */
const enum anv_bo_alloc_flags not_allowed_promotion = ANV_BO_ALLOC_SCANOUT |
ANV_BO_ALLOC_EXTERNAL |