From 9164ea7032dc2aa36aebb46d110eb3c9356d62af Mon Sep 17 00:00:00 2001
From: Karmjit Mahil <karmjit.mahil@igalia.com>
Date: Tue, 18 Jun 2024 16:32:06 +0200
Subject: [PATCH] freedreno/isa: Fix isaspec map for a3xx-ld

When LDP uses a negative offset (which it valid), since
`struct ir3_register` uses `{i,u}nt32_t` for the immediate
values, using `extract_reg_uim()` wasn't sign extending
negative immediate values.

Addresses:
```
src/freedreno/isa/encode.h:84:
pack_field: Assertion '!(( val & ~BITFIELD64_MASK(1 + high - low)) &&
                         (~val & ~BITFIELD64_MASK(1 + high - low)))' failed.
```
seen in https://gitlab.freedesktop.org/mesa/mesa/-/issues/11153 .

Signed-off-by: Karmjit Mahil <karmjit.mahil@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29768>
---
 src/freedreno/isa/ir3-cat6.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/freedreno/isa/ir3-cat6.xml b/src/freedreno/isa/ir3-cat6.xml
index 09d76b32a77..0e331cf62e9 100644
--- a/src/freedreno/isa/ir3-cat6.xml
+++ b/src/freedreno/isa/ir3-cat6.xml
@@ -335,7 +335,7 @@ SOFTWARE.
 	<pattern low="40" high="48">xxxxxxxxx</pattern>
 	<pattern low="52" high="53">xx</pattern>
 	<encode>
-		<map name="OFF">extract_reg_uim(src->srcs[1])</map>
+		<map name="OFF">extract_reg_iim(src->srcs[1])</map>
 		<map name="SRC">src->srcs[0]</map>
 		<map name="SIZE">extract_reg_uim(src->srcs[2])</map>
 	</encode>