From 8b1eed39ad1aacdbd55bbafa74e41ecb47bcb216 Mon Sep 17 00:00:00 2001 From: Mary Guillemard Date: Tue, 18 Jun 2024 12:03:41 +0200 Subject: [PATCH] panvk: Add missing clean up in blend_shader_cache_init When pan_blend_shader_key_table_create was failing, we weren't destroying the mutex and panvk_pool. Signed-off-by: Mary Guillemard Reviewed-by: Boris Brezillon Part-of: --- src/panfrost/vulkan/panvk_vX_blend.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/panfrost/vulkan/panvk_vX_blend.c b/src/panfrost/vulkan/panvk_vX_blend.c index c58365edc44..defd17aef96 100644 --- a/src/panfrost/vulkan/panvk_vX_blend.c +++ b/src/panfrost/vulkan/panvk_vX_blend.c @@ -38,9 +38,12 @@ panvk_per_arch(blend_shader_cache_init)(struct panvk_device *dev) panvk_pool_init(&cache->bin_pool, dev, NULL, &bin_pool_props); cache->ht = pan_blend_shader_key_table_create(NULL); - if (!cache->ht) + if (!cache->ht) { + panvk_pool_cleanup(&cache->bin_pool); + simple_mtx_destroy(&cache->lock); return vk_errorf(dev, VK_ERROR_OUT_OF_HOST_MEMORY, "couldn't create blend shader hash table"); + } return VK_SUCCESS; }