OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v3dv: remove unused clamp_to_transparent_black_border property

Browse Source 
Commit e07c5467 ("v3dv/format: use XYZ1 swizzle for three-component formats")
removes the only code that handled the clamp_to_transparent_black_border
variable. Therefore, the variable can be deleted, as it is not currently
being used.

Fixes: e07c5467 ("v3dv/format: use XYZ1 swizzle for three-component formats")
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20746>
This commit is contained in:
Maíra Canal
2023-01-17 10:20:45 -03:00
committed by Marge Bot
parent 11669c96bc
commit 86c9bdcd9a
2 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/broadcom/vulkan/v3dv_private.h
View File

@@ -2122,7 +2122,6 @@ struct v3dv_sampler {
bool compare_enable; bool compare_enable;
bool unnormalized_coordinates; bool unnormalized_coordinates;
bool clamp_to_transparent_black_border;
/* Prepacked per plane SAMPLER_STATE, that is referenced as part of the tmu /* Prepacked per plane SAMPLER_STATE, that is referenced as part of the tmu
* configuration. If needed it will be copied to the descriptor info during * configuration. If needed it will be copied to the descriptor info during

15
src/broadcom/vulkan/v3dvx_device.c
View File

@@ -203,21 +203,6 @@ v3dX(pack_sampler_state)(struct v3dv_sampler *sampler,
break; break;
} }
/* For some texture formats, when clamping to transparent black border the
* CTS expects alpha to be set to 1 instead of 0, but the border color mode
* will take priority over the texture state swizzle, so the only way to
* fix that is to apply a swizzle in the shader. Here we keep track of
* whether we are activating that mode and we will decide if we need to
* activate the texture swizzle lowering in the shader key at compile time
* depending on the actual texture format.
*/
if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER ||
pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER ||
pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) &&
border_color_mode == V3D_BORDER_COLOR_0000) {
sampler->clamp_to_transparent_black_border = true;
}
v3dvx_pack(sampler->sampler_state, SAMPLER_STATE, s) { v3dvx_pack(sampler->sampler_state, SAMPLER_STATE, s) {
if (pCreateInfo->anisotropyEnable) { if (pCreateInfo->anisotropyEnable) {
s.anisotropy_enable = true; s.anisotropy_enable = true;