OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

aco/lower_to_hw_instr: Check the right instruction's opcode

Browse Source 
instr is the branch instruction, its opcode won't ever be writelane. We
should check inst instead.

Found by inspection.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32389>
This commit is contained in:
Friedrich Vock
2024-11-10 13:12:12 +01:00
committed by Marge Bot
parent 28ab7f0168
commit 845660f2b7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/amd/compiler/aco_lower_to_hw_instr.cpp
View File

@@ -2898,8 +2898,8 @@ lower_to_hw_instr(Program* program)
} else if (inst->isSALU()) {
num_scalar++;
} else if (inst->isVALU() || inst->isVINTRP()) {
if (instr->opcode == aco_opcode::v_writelane_b32 ||
instr->opcode == aco_opcode::v_writelane_b32_e64) {
if (inst->opcode == aco_opcode::v_writelane_b32 ||
inst->opcode == aco_opcode::v_writelane_b32_e64) {
/* writelane ignores exec, writing inactive lanes results in UB. */
can_remove = false;
}