glcpp-test: don't return failure if valgrind tests aren't run
Success was (tests-passed AND valgrind-tests-passed) but this meant that if the valgrind tests weren't run it would be considered a failure. The logic is now (tests-passed AND (!valgrind OR valgrind-tests-passed)) which lets us return success if the valgrind tests aren't run. Reviewed-by: Eric Anholt <eric@anholt.net> Tested-by: Eric Anholt <eric@anholt.net> Signed-off-by: Matt Turner <mattst88@gmail.com>
This commit is contained in:
@@ -72,7 +72,7 @@ if [ "$do_valgrind" = "yes" ]; then
|
||||
echo "$clean/$total tests are valgrind-clean"
|
||||
fi
|
||||
|
||||
if [ "$pass" = "$total" ] && [ "$clean" = "$total" ]; then
|
||||
if [ "$pass" = "$total" ] && [ "$do_valgrind" != "yes" ] || [ "$pass" = "$total" ]; then
|
||||
exit 0
|
||||
else
|
||||
exit 1
|
||||
|
Reference in New Issue
Block a user