OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glsl: Use ir_rvalue to represent generic error_type values.

Browse Source 
Currently, ir_call can be used as either a statement (for void
functions) or a value (for non-void functions).  This is rather awkward,
as it's the only class that can be used in both forms.

A number of places use ir_call::get_error_instruction() to construct a
generic value of error_type.  If ir_call is to become a statement, it
can no longer serve this purpose.

Unfortunately, none of our classes are particularly well suited for
this, and creating a new one would be rather aggrandizing.  So, this
patch introduces ir_rvalue::error_value(), a static method that creates
an instance of the base class, ir_rvalue.  This has the nice property
that you can't accidentally try and access uninitialized fields (as it
doesn't have any).  The downside is that the base class is no longer
abstract.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
This commit is contained in:
Kenneth Graunke
2011-09-22 15:04:56 -07:00
parent ac0f8bae8d
commit 807e967c61
13 changed files with 80 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/glsl/ir.cpp
View File

@@ -1458,13 +1458,13 @@ ir_function::has_user_signature()
}
ir_call *
ir_call::get_error_instruction(void *ctx)
ir_rvalue *
ir_rvalue::error_value(void *mem_ctx)
{
ir_call *call = new(ctx) ir_call;
ir_rvalue *v = new(mem_ctx) ir_rvalue;
call->type = glsl_type::error_type;
return call;
v->type = glsl_type::error_type;
return v;
}
void