anv/android: Re-implement AcquireImageANDROID

Instead of doing a vkQueueSubmit() and hoping for the best, use the
actual sync FD that gets passed in from SurfaceFlinger.  The semaphore
and fence FD import functions already handle the -1 case for us so the
implementation is almost trivial.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Tested-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Chad Versace <chad@kiwitree.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8814>

src/intel/vulkan/anv_android.c

@@ -710,67 +710,72 @@ anv_AcquireImageANDROID(
    ANV_FROM_HANDLE(anv_device, device, device_h);
    VkResult result = VK_SUCCESS;
 
-   if (nativeFenceFd != -1) {
+   /* From https://source.android.com/devices/graphics/implement-vulkan :
-      /* As a simple, firstpass implementation of VK_ANDROID_native_buffer, we
+    *
-       * block on the nativeFenceFd. This may introduce latency and is
+    *    "The driver takes ownership of the fence file descriptor and closes
-       * definitiely inefficient, yet it's correct.
+    *    the fence file descriptor when no longer needed. The driver must do
-       *
+    *    so even if neither a semaphore or fence object is provided, or even
-       * FINISHME(chadv): Import the nativeFenceFd into the VkSemaphore and
+    *    if vkAcquireImageANDROID fails and returns an error."
-       * VkFence.
+    *
-       */
+    * The Vulkan spec for VkImportFence/SemaphoreFdKHR(), however, requires
-      if (sync_wait(nativeFenceFd, /*timeout*/ -1) < 0) {
+    * the file descriptor to be left alone on failure.
-         result = vk_errorf(device, device, VK_ERROR_DEVICE_LOST,
+    */
-                            "%s: failed to wait on nativeFenceFd=%d",
+   int semaphore_fd = -1, fence_fd = -1;
-                            __func__, nativeFenceFd);
+   if (nativeFenceFd >= 0) {
+      if (semaphore_h != VK_NULL_HANDLE && fence_h != VK_NULL_HANDLE) {
+         /* We have both so we have to import the sync file twice. One of
+          * them needs to be a dup.
+          */
+         semaphore_fd = nativeFenceFd;
+         fence_fd = dup(nativeFenceFd);
+         if (fence_fd < 0) {
+            VkResult err = (errno == EMFILE) ? VK_ERROR_TOO_MANY_OBJECTS :
+                                               VK_ERROR_OUT_OF_HOST_MEMORY;
+            close(nativeFenceFd);
+            return vk_error(err);
+         }
+      } else if (semaphore_h != VK_NULL_HANDLE) {
+         semaphore_fd = nativeFenceFd;
+      } else if (fence_h == VK_NULL_HANDLE) {
+         fence_fd = nativeFenceFd;
+      } else {
+         /* Nothing to import into so we have to close the file */
+         close(nativeFenceFd);
       }
-
-      /* From VK_ANDROID_native_buffer's pseudo spec
-       * (https://source.android.com/devices/graphics/implement-vulkan):
-       *
-       *    The driver takes ownership of the fence fd and is responsible for
-       *    closing it [...] even if vkAcquireImageANDROID fails and returns
-       *    an error.
-       */
-      close(nativeFenceFd);
-
-      if (result != VK_SUCCESS)
-         return result;
    }
 
-   if (semaphore_h || fence_h) {
+   if (semaphore_h != VK_NULL_HANDLE) {
-      /* Thanks to implicit sync, the image is ready for GPU access.  But we
+      const VkImportSemaphoreFdInfoKHR info = {
-       * must still put the semaphore into the "submit" state; otherwise the
+         .sType = VK_STRUCTURE_TYPE_IMPORT_SEMAPHORE_FD_INFO_KHR,
-       * client may get unexpected behavior if the client later uses it as
+         .semaphore = semaphore_h,
-       * a wait semaphore.
+         .flags = VK_SEMAPHORE_IMPORT_TEMPORARY_BIT,
-       *
+         .handleType = VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT,
-       * Because we blocked above on the nativeFenceFd, the image is also
+         .fd = semaphore_fd,
-       * ready for foreign-device access (including CPU access). But we must
-       * still signal the fence; otherwise the client may get unexpected
-       * behavior if the client later waits on it.
-       *
-       * For some values of anv_semaphore_type, we must submit the semaphore
-       * to execbuf in order to signal it.  Likewise for anv_fence_type.
-       * Instead of open-coding here the signal operation for each
-       * anv_semaphore_type and anv_fence_type, we piggy-back on
-       * vkQueueSubmit.
-       */
-      const VkSubmitInfo submit = {
-         .sType = VK_STRUCTURE_TYPE_SUBMIT_INFO,
-         .waitSemaphoreCount = 0,
-         .commandBufferCount = 0,
-         .signalSemaphoreCount = (semaphore_h ? 1 : 0),
-         .pSignalSemaphores = &semaphore_h,
       };
-
+      result = anv_ImportSemaphoreFdKHR(device_h, &info);
-      result = anv_QueueSubmit(anv_queue_to_handle(&device->queue), 1,
+      if (result == VK_SUCCESS)
-                               &submit, fence_h);
+         semaphore_fd = -1; /* ANV took ownership */
-      if (result != VK_SUCCESS) {
-         return vk_errorf(device, device, result,
-                          "anv_QueueSubmit failed inside %s", __func__);
-      }
    }
 
-   return VK_SUCCESS;
+   if (result == VK_SUCCESS && fence_h != VK_NULL_HANDLE) {
+      const VkImportFenceFdInfoKHR info = {
+         .sType = VK_STRUCTURE_TYPE_IMPORT_FENCE_FD_INFO_KHR,
+         .fence = fence_h,
+         .flags = VK_FENCE_IMPORT_TEMPORARY_BIT,
+         .handleType = VK_EXTERNAL_FENCE_HANDLE_TYPE_SYNC_FD_BIT,
+         .fd = fence_fd,
+      };
+      result = anv_ImportFenceFdKHR(device_h, &info);
+      if (result == VK_SUCCESS)
+         fence_fd = -1; /* ANV took ownership */
+   }
+
+   if (semaphore_fd >= 0)
+      close(semaphore_fd);
+   if (fence_fd >= 0)
+      close(fence_fd);
+
+   return result;
 }
 
 VkResult