From 7c351a6f5d4d4566b05f5cfb1df5d5b51cf061d2 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Thu, 24 Sep 2020 19:13:43 -0400 Subject: [PATCH] pan/decode: Ensure mappings are zeroed Fixes valgrind error when running with =sync ==30966== Conditional jump or move depends on uninitialised value(s) ==30966== at 0x5B424E8: pandecode_find_mapped_gpu_mem_containing (decode_common.c:56) ==30966== by 0x5B4CFB7: pandecode_jc (decode.c:2075) ==30966== by 0x5ABBFA7: panfrost_batch_submit_ioctl (pan_job.c:1020) ==30966== by 0x5ABD397: panfrost_batch_submit_jobs (pan_job.c:1042) ==30966== by 0x5ABD397: panfrost_batch_submit (pan_job.c:1109) Signed-off-by: Alyssa Rosenzweig Reviewed-by: Boris Brezillon Part-of: --- src/panfrost/lib/decode_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panfrost/lib/decode_common.c b/src/panfrost/lib/decode_common.c index 14cb2f092c1..53f2a50de7d 100644 --- a/src/panfrost/lib/decode_common.c +++ b/src/panfrost/lib/decode_common.c @@ -104,7 +104,7 @@ pandecode_inject_mmap(uint64_t gpu_va, void *cpu, unsigned sz, const char *name) /* Otherwise, add a fresh mapping */ struct pandecode_mapped_memory *mapped_mem = NULL; - mapped_mem = malloc(sizeof(*mapped_mem)); + mapped_mem = calloc(1, sizeof(*mapped_mem)); mapped_mem->gpu_va = gpu_va; mapped_mem->length = sz; mapped_mem->addr = cpu;