OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

anv: Call vk_command_buffer_finish if create fails

Browse Source 
This wasn't much of a problem before because vk_command_buffer_finish()
doesn't do much on an empty command buffer.  However, it's about to be
responsible for managing the pool's list of command buffers so it will
be critical to get this right.

Fixes: c9189f4813 ("anv: Use a common vk_command_buffer structure")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14917>
This commit is contained in:
Jason Ekstrand
2022-02-08 16:04:34 -06:00
committed by Marge Bot
parent cb50e4ac4d
commit 7b0e306854
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/intel/vulkan/anv_cmd_buffer.c
View File

@@ -277,7 +277,7 @@ static VkResult anv_create_cmd_buffer(
result = vk_command_buffer_init(&cmd_buffer->vk, &device->vk);
if (result != VK_SUCCESS)
goto fail;
goto fail_alloc;
cmd_buffer->batch.status = VK_SUCCESS;
@@ -287,7 +287,7 @@ static VkResult anv_create_cmd_buffer(
result = anv_cmd_buffer_init_batch_bo_chain(cmd_buffer);
if (result != VK_SUCCESS)
goto fail;
goto fail_vk;
anv_state_stream_init(&cmd_buffer->surface_state_stream,
&device->surface_state_pool, 4096);
@@ -310,7 +310,9 @@ static VkResult anv_create_cmd_buffer(
return VK_SUCCESS;
fail:
fail_vk:
vk_command_buffer_finish(&cmd_buffer->vk);
fail_alloc:
vk_free2(&device->vk.alloc, &pool->alloc, cmd_buffer);
return result;