From 79cd22b889b401665cb92a6a4dcafa30c26dc298 Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Tue, 27 Oct 2020 12:39:53 +0100 Subject: [PATCH] v3dv: enable alphaToOne feature MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is another case of a feature that is implemented in the compiler and that only required that we set the shader key properly from the pipeline state, which we were already doing. I verified we pass the tests in dEQP-VK.pipeline.multisample.alpha_to_one.* (we only support 4x multisampling, so we can only pass a single test there), however, the tests seem to have a bug by which they always pass, even if the driver doesn't actually implement alpha to one correctly. I submitted a fix to Khronos and verified that we also pass the fixed tests (and that we failed them if we don't actually set te shader key correctly). Reviewed-by: Alejandro Piñeiro Part-of: --- src/broadcom/vulkan/v3dv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/broadcom/vulkan/v3dv_device.c b/src/broadcom/vulkan/v3dv_device.c index 501c042c167..55755f5ef84 100644 --- a/src/broadcom/vulkan/v3dv_device.c +++ b/src/broadcom/vulkan/v3dv_device.c @@ -685,7 +685,7 @@ v3dv_GetPhysicalDeviceFeatures(VkPhysicalDevice physicalDevice, .depthBounds = false, /* Only available since V3D 4.3.16.2 */ .wideLines = true, .largePoints = true, - .alphaToOne = false, + .alphaToOne = true, .multiViewport = false, .samplerAnisotropy = true, .textureCompressionETC2 = true,