OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel/disasm: Remove duplicate variable reg_file

Browse Source 
Fix defects reported by Coverity Scan.

Evaluation order violation (EVALUATION_ORDER)
write_write_typo: In reg_file = reg_file = brw_inst_dpas_3src_dst_reg_file(devinfo, inst),
reg_file is written twice with the same value.

Fixes: 1c92dad5cb ("intel/disasm: Disassembly support for DPAS")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27056>
This commit is contained in:
Vinson Lee
2024-01-13 21:06:38 -08:00
committed by Marge Bot
parent e84aa455e5
commit 73835874a8
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/intel/compiler/brw_disasm.c
View File

@@ -1061,8 +1061,7 @@ static int
dest_dpas_3src(FILE *file, const struct intel_device_info *devinfo,
const brw_inst *inst)
{
uint32_t reg_file =
reg_file = brw_inst_dpas_3src_dst_reg_file(devinfo, inst);
uint32_t reg_file = brw_inst_dpas_3src_dst_reg_file(devinfo, inst);
if (reg(file, reg_file, brw_inst_dpas_3src_dst_reg_nr(devinfo, inst)) == -1)
return 0;
@@ -1557,8 +1556,7 @@ static int
src0_dpas_3src(FILE *file, const struct intel_device_info *devinfo,
const brw_inst *inst)
{
uint32_t reg_file =
reg_file = brw_inst_dpas_3src_src0_reg_file(devinfo, inst);
uint32_t reg_file = brw_inst_dpas_3src_src0_reg_file(devinfo, inst);
if (reg(file, reg_file, brw_inst_dpas_3src_src0_reg_nr(devinfo, inst)) == -1)
return 0;
@@ -1579,8 +1577,7 @@ static int
src1_dpas_3src(FILE *file, const struct intel_device_info *devinfo,
const brw_inst *inst)
{
uint32_t reg_file =
reg_file = brw_inst_dpas_3src_src1_reg_file(devinfo, inst);
uint32_t reg_file = brw_inst_dpas_3src_src1_reg_file(devinfo, inst);
if (reg(file, reg_file, brw_inst_dpas_3src_src1_reg_nr(devinfo, inst)) == -1)
return 0;
@@ -1601,8 +1598,7 @@ static int
src2_dpas_3src(FILE *file, const struct intel_device_info *devinfo,
const brw_inst *inst)
{
uint32_t reg_file =
reg_file = brw_inst_dpas_3src_src2_reg_file(devinfo, inst);
uint32_t reg_file = brw_inst_dpas_3src_src2_reg_file(devinfo, inst);
if (reg(file, reg_file, brw_inst_dpas_3src_src2_reg_nr(devinfo, inst)) == -1)
return 0;