OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel/fs: Use groups for SIMD16 LINTERP on gen11+

Browse Source 
This is better than compression control because it naturally extends to
SIMD32.

v2:
 - Push/pop instruction state around adjusted codegen (Ken)

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Matt Turner <mattst88@gmail.com>
This commit is contained in:
Jason Ekstrand
2018-05-16 17:33:17 -07:00
parent a1a850cd34
commit 71a86d1fc6
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/intel/compiler/brw_fs_generator.cpp
View File

@@ -781,6 +781,7 @@ fs_generator::generate_linterp(fs_inst *inst,
struct brw_reg dwQ = suboffset(interp, 1); struct brw_reg dwQ = suboffset(interp, 1);
struct brw_reg dwR = suboffset(interp, 3); struct brw_reg dwR = suboffset(interp, 3);
brw_push_insn_state(p);
brw_set_default_exec_size(p, BRW_EXECUTE_8); brw_set_default_exec_size(p, BRW_EXECUTE_8);
if (inst->exec_size == 8) { if (inst->exec_size == 8) {
@@ -795,16 +796,14 @@ fs_generator::generate_linterp(fs_inst *inst,
*/ */
brw_inst_set_saturate(p->devinfo, i[0], false); brw_inst_set_saturate(p->devinfo, i[0], false);
} else { } else {
brw_set_default_compression_control(p, BRW_COMPRESSION_NONE); brw_set_default_group(p, inst->group);
i[0] = brw_MAD(p, acc, dwR, offset(delta_x, 0), dwP); i[0] = brw_MAD(p, acc, dwR, offset(delta_x, 0), dwP);
i[1] = brw_MAD(p, offset(dst, 0), acc, offset(delta_x, 1), dwQ); i[1] = brw_MAD(p, offset(dst, 0), acc, offset(delta_x, 1), dwQ);
brw_set_default_compression_control(p, BRW_COMPRESSION_2NDHALF); brw_set_default_group(p, inst->group + 8);
i[2] = brw_MAD(p, acc, dwR, offset(delta_y, 0), dwP); i[2] = brw_MAD(p, acc, dwR, offset(delta_y, 0), dwP);
i[3] = brw_MAD(p, offset(dst, 1), acc, offset(delta_y, 1), dwQ); i[3] = brw_MAD(p, offset(dst, 1), acc, offset(delta_y, 1), dwQ);
brw_set_default_compression_control(p, BRW_COMPRESSION_COMPRESSED);
brw_inst_set_cond_modifier(p->devinfo, i[1], inst->conditional_mod); brw_inst_set_cond_modifier(p->devinfo, i[1], inst->conditional_mod);
brw_inst_set_cond_modifier(p->devinfo, i[3], inst->conditional_mod); brw_inst_set_cond_modifier(p->devinfo, i[3], inst->conditional_mod);
@@ -816,6 +815,8 @@ fs_generator::generate_linterp(fs_inst *inst,
brw_inst_set_saturate(p->devinfo, i[2], false); brw_inst_set_saturate(p->devinfo, i[2], false);
} }
brw_pop_insn_state(p);
return true; return true;
} else if (devinfo->has_pln) { } else if (devinfo->has_pln) {
/* From the Sandy Bridge PRM Vol. 4, Pt. 2, Section 8.3.53, "Plane": /* From the Sandy Bridge PRM Vol. 4, Pt. 2, Section 8.3.53, "Plane":