From 6edc2a3d40406f5b0a5edd5bcccd3232ad50a61f Mon Sep 17 00:00:00 2001 From: Ian Romanick Date: Thu, 30 Jul 2020 11:33:03 -0700 Subject: [PATCH] intel/compiler: Rotate instructions ROR and ROL cannot have source modifiers I checked the Bspec for both Gen11 and Gen12, and it appears that rotate instructions cannot have source modifiers or saturate modifer. Saturate was already handled. Fixes: 1e92e83856b ("intel/compiler: Emit ROR and ROL instruction") Reviewed-by: Caio Marcelo de Oliveira Filho Reviewed-by: Sagar Ghuge Part-of: --- src/intel/compiler/brw_shader.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/compiler/brw_shader.cpp b/src/intel/compiler/brw_shader.cpp index c44becfe0a1..19acf8fa87e 100644 --- a/src/intel/compiler/brw_shader.cpp +++ b/src/intel/compiler/brw_shader.cpp @@ -937,6 +937,8 @@ backend_instruction::can_do_source_mods() const case BRW_OPCODE_CBIT: case BRW_OPCODE_FBH: case BRW_OPCODE_FBL: + case BRW_OPCODE_ROL: + case BRW_OPCODE_ROR: case BRW_OPCODE_SUBB: case SHADER_OPCODE_BROADCAST: case SHADER_OPCODE_CLUSTER_BROADCAST: