compiler/blob: make blob_reserve_bytes() more useful
Despite the name, it could only be used if you immediately wrote to the pointer. Noboby was using it outside of one test, so clearly this behavior wasn't that useful. Instead, make it return an offset into the data buffer so that the result isn't invalidated if you later write to the blob. In conjunction with blob_overwrite_bytes(), this will be useful for leaving a placeholder and then filling it in later, which we'll need to do for handling phi nodes when serializing NIR. v2 (Jason Ekstrand): - Detect overflow in the offset + to_write computation Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
This commit is contained in:

committed by
Jason Ekstrand

parent
8ae03af4ed
commit
6935440967
@@ -120,7 +120,7 @@ test_write_and_read_functions (void)
|
||||
{
|
||||
struct blob blob;
|
||||
struct blob_reader reader;
|
||||
uint8_t *reserved;
|
||||
ssize_t reserved;
|
||||
size_t str_offset, uint_offset;
|
||||
uint8_t reserve_buf[sizeof(reserve_test_str)];
|
||||
|
||||
@@ -131,7 +131,7 @@ test_write_and_read_functions (void)
|
||||
blob_write_bytes(&blob, bytes_test_str, sizeof(bytes_test_str));
|
||||
|
||||
reserved = blob_reserve_bytes(&blob, sizeof(reserve_test_str));
|
||||
memcpy(reserved, reserve_test_str, sizeof(reserve_test_str));
|
||||
blob_overwrite_bytes(&blob, reserved, reserve_test_str, sizeof(reserve_test_str));
|
||||
|
||||
/* Write a placeholder, (to be replaced later via overwrite_bytes) */
|
||||
str_offset = blob.size;
|
||||
|
Reference in New Issue
Block a user