OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mesa: Require current libxcb.

Browse Source 
Without that, people with buggy apps that looked at just the server
string for GLX_ARB_create_context would call this function that just
threw an error when you tried to make a context.  Google shows plenty
of complaints about this.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
This commit is contained in:
Eric Anholt
2012-07-04 11:58:40 -07:00
parent f92873be2c
commit 6882381a2e
5 changed files with 2 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/glx/create_context.c
View File

@@ -99,7 +99,6 @@ glXCreateContextAttribsARB(Display *dpy, GLXFBConfig config,
* the protocol error and handle it. Part of handling the error is freeing
* the possibly non-NULL value returned by this function.
*/
#ifdef HAVE_XCB_GLX_CREATE_CONTEXT
cookie =
xcb_glx_create_context_attribs_arb_checked(c,
gc->xid,
@@ -111,19 +110,6 @@ glXCreateContextAttribsARB(Display *dpy, GLXFBConfig config,
(const uint32_t *)
attrib_list);
err = xcb_request_check(c, cookie);
#else
/* This is a hugely ugly hack to make things compile on systems that lack
* the proper XCB version.
*/
memset(&cookie, 0, sizeof(cookie));
err = calloc(1, sizeof(*err));
err->error_code = BadRequest;
err->sequence = dpy->request;
err->resource_id = gc->xid;
err->minor_code = gc->majorOpcode;
err->major_code = 34;
#endif
if (err != NULL) {
gc->vtable->destroy(gc);
gc = NULL;