OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radv: remove absolute_depth_bias workaround

Browse Source 
This was only used with Path of Exile and the game bug seems fixed.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25198>
This commit is contained in:
Samuel Pitoiset
2023-09-13 08:37:22 +02:00
committed by Marge Bot
parent 4475c400a1
commit 67ed899cd6
4 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/amd/vulkan/radv_cmd_buffer.c
View File

@@ -2109,15 +2109,13 @@ radv_emit_depth_bounds(struct radv_cmd_buffer *cmd_buffer)
static void static void
radv_emit_depth_bias(struct radv_cmd_buffer *cmd_buffer) radv_emit_depth_bias(struct radv_cmd_buffer *cmd_buffer)
{ {
const struct radv_device *device = cmd_buffer->device;
const struct radv_dynamic_state *d = &cmd_buffer->state.dynamic; const struct radv_dynamic_state *d = &cmd_buffer->state.dynamic;
struct radv_rendering_state *render = &cmd_buffer->state.render; struct radv_rendering_state *render = &cmd_buffer->state.render;
unsigned slope = fui(d->vk.rs.depth_bias.slope * 16.0f); unsigned slope = fui(d->vk.rs.depth_bias.slope * 16.0f);
unsigned pa_su_poly_offset_db_fmt_cntl = 0; unsigned pa_su_poly_offset_db_fmt_cntl = 0;
if (vk_format_has_depth(render->ds_att.format) && if (vk_format_has_depth(render->ds_att.format) &&
d->vk.rs.depth_bias.representation != VK_DEPTH_BIAS_REPRESENTATION_FLOAT_EXT && d->vk.rs.depth_bias.representation != VK_DEPTH_BIAS_REPRESENTATION_FLOAT_EXT) {
!device->instance->absolute_depth_bias) {
VkFormat format = vk_format_depth_only(render->ds_att.format); VkFormat format = vk_format_depth_only(render->ds_att.format);
if (format == VK_FORMAT_D16_UNORM) { if (format == VK_FORMAT_D16_UNORM) {

3
src/amd/vulkan/radv_instance.c
View File

@@ -128,7 +128,6 @@ static const driOptionDescription radv_dri_options[] = {
DRI_CONF_RADV_ENABLE_MRT_OUTPUT_NAN_FIXUP(false) DRI_CONF_RADV_ENABLE_MRT_OUTPUT_NAN_FIXUP(false)
DRI_CONF_RADV_DISABLE_SHRINK_IMAGE_STORE(false) DRI_CONF_RADV_DISABLE_SHRINK_IMAGE_STORE(false)
DRI_CONF_RADV_NO_DYNAMIC_BOUNDS(false) DRI_CONF_RADV_NO_DYNAMIC_BOUNDS(false)
DRI_CONF_RADV_ABSOLUTE_DEPTH_BIAS(false)
DRI_CONF_RADV_OVERRIDE_UNIFORM_OFFSET_ALIGNMENT(0) DRI_CONF_RADV_OVERRIDE_UNIFORM_OFFSET_ALIGNMENT(0)
DRI_CONF_SECTION_END DRI_CONF_SECTION_END
@@ -169,8 +168,6 @@ radv_init_dri_options(struct radv_instance *instance)
instance->disable_shrink_image_store = driQueryOptionb(&instance->dri_options, "radv_disable_shrink_image_store"); instance->disable_shrink_image_store = driQueryOptionb(&instance->dri_options, "radv_disable_shrink_image_store");
instance->absolute_depth_bias = driQueryOptionb(&instance->dri_options, "radv_absolute_depth_bias");
instance->disable_tc_compat_htile_in_general = instance->disable_tc_compat_htile_in_general =
driQueryOptionb(&instance->dri_options, "radv_disable_tc_compat_htile_general"); driQueryOptionb(&instance->dri_options, "radv_disable_tc_compat_htile_general");

1
src/amd/vulkan/radv_private.h
View File

@@ -404,7 +404,6 @@ struct radv_instance {
bool enable_mrt_output_nan_fixup; bool enable_mrt_output_nan_fixup;
bool disable_tc_compat_htile_in_general; bool disable_tc_compat_htile_in_general;
bool disable_shrink_image_store; bool disable_shrink_image_store;
bool absolute_depth_bias;
bool disable_aniso_single_level; bool disable_aniso_single_level;
bool zero_vram; bool zero_vram;
bool disable_sinking_load_input_fs; bool disable_sinking_load_input_fs;

4
src/util/driconf.h
View File

@@ -597,10 +597,6 @@
DRI_CONF_OPT_B(radv_disable_shrink_image_store, def, \ DRI_CONF_OPT_B(radv_disable_shrink_image_store, def, \
"Disabling shrinking of image stores based on the format") "Disabling shrinking of image stores based on the format")
#define DRI_CONF_RADV_ABSOLUTE_DEPTH_BIAS(def) \
DRI_CONF_OPT_B(radv_absolute_depth_bias, def, \
"Consider depthBiasConstantFactor an absolute depth bias (like D3D9)")
#define DRI_CONF_RADV_OVERRIDE_UNIFORM_OFFSET_ALIGNMENT(def) \ #define DRI_CONF_RADV_OVERRIDE_UNIFORM_OFFSET_ALIGNMENT(def) \
DRI_CONF_OPT_I(radv_override_uniform_offset_alignment, def, 0, 128, \ DRI_CONF_OPT_I(radv_override_uniform_offset_alignment, def, 0, 128, \
"Override the minUniformBufferOffsetAlignment exposed to the application. (0 = default)") "Override the minUniformBufferOffsetAlignment exposed to the application. (0 = default)")