OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

panfrost: fix UB caused by shifting signed int too far

Browse Source 
Fixes: 13d7ca1300 ("pan/va: Optimize add with imm to ADD_IMM")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27437>
This commit is contained in:
Eric Engestrom
2024-02-02 11:16:22 +00:00
committed by Marge Bot
parent 2085d60438
commit 6250885640
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/panfrost/compiler/valhall/va_optimize.c
View File

@@ -106,9 +106,9 @@ va_fuse_add_imm(bi_instr *I)
/* If the constant is negated, flip the sign bit */
if (I->src[s].neg) {
if (I->op == BI_OPCODE_FADD_IMM_F32)
I->index ^= (1 << 31);
I->index ^= (1u << 31);
else if (I->op == BI_OPCODE_FADD_IMM_V2F16)
I->index ^= (1 << 31) | (1 << 15);
I->index ^= (1u << 31) | (1u << 15);
else
unreachable("unexpected .neg");
}