OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadcom/qpu: Remove duplicate variable opcode

Browse Source 
Fix defect reported by Coverity Scan.

Evaluation order violation (EVALUATION_ORDER)
write_write_typo: In opcode = opcode = desc->opcode_first, opcode is
written twice with the same value.

Fixes: 3b20208f03 ("broadcom/qpu: add pack/unpack support for v71")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25735>
This commit is contained in:
Vinson Lee
2023-10-14 21:39:54 -07:00
committed by Marge Bot
parent b207608995
commit 5612f9a704
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/broadcom/qpu/qpu_pack.c
View File

@@ -1602,7 +1602,7 @@ v3d33_qpu_add_pack(const struct v3d_device_info *devinfo,
if (!desc)
return false;
uint32_t opcode = opcode = desc->opcode_first;
uint32_t opcode = desc->opcode_first;
/* If an operation doesn't use an arg, its mux values may be used to
* identify the operation type.
@@ -1816,7 +1816,7 @@ v3d71_qpu_add_pack(const struct v3d_device_info *devinfo,
if (!desc)
return false;
uint32_t opcode = opcode = desc->opcode_first;
uint32_t opcode = desc->opcode_first;
/* If an operation doesn't use an arg, its raddr values may be used to
* identify the operation type.