glsl: Allow vectors to be created from ir_constant().

Note the parameter name change in the int version of ir_constant, to
avoid the conflict with the loop iterator.

v2: Make analogous change to builtin_builder::imm().
Reviewed-by: Paul Berry <stereotype441@gmail.com>
This commit is contained in:
Matt Turner
2013-08-05 15:15:37 -07:00
parent b2ab840130
commit 5561251b58
3 changed files with 41 additions and 29 deletions

View File

@@ -348,9 +348,9 @@ private:
*/ */
ir_variable *in_var(const glsl_type *type, const char *name); ir_variable *in_var(const glsl_type *type, const char *name);
ir_variable *out_var(const glsl_type *type, const char *name); ir_variable *out_var(const glsl_type *type, const char *name);
ir_constant *imm(float f); ir_constant *imm(float f, unsigned vector_elements=1);
ir_constant *imm(int i); ir_constant *imm(int i, unsigned vector_elements=1);
ir_constant *imm(unsigned u); ir_constant *imm(unsigned u, unsigned vector_elements=1);
ir_constant *imm(const glsl_type *type, const ir_constant_data &); ir_constant *imm(const glsl_type *type, const ir_constant_data &);
ir_dereference_variable *var_ref(ir_variable *var); ir_dereference_variable *var_ref(ir_variable *var);
ir_dereference_array *array_ref(ir_variable *var, int i); ir_dereference_array *array_ref(ir_variable *var, int i);
@@ -1878,21 +1878,21 @@ builtin_builder::out_var(const glsl_type *type, const char *name)
} }
ir_constant * ir_constant *
builtin_builder::imm(float f) builtin_builder::imm(float f, unsigned vector_elements)
{ {
return new(mem_ctx) ir_constant(f); return new(mem_ctx) ir_constant(f, vector_elements);
} }
ir_constant * ir_constant *
builtin_builder::imm(int i) builtin_builder::imm(int i, unsigned vector_elements)
{ {
return new(mem_ctx) ir_constant(i); return new(mem_ctx) ir_constant(i, vector_elements);
} }
ir_constant * ir_constant *
builtin_builder::imm(unsigned u) builtin_builder::imm(unsigned u, unsigned vector_elements)
{ {
return new(mem_ctx) ir_constant(u); return new(mem_ctx) ir_constant(u, vector_elements);
} }
ir_constant * ir_constant *

View File

@@ -619,42 +619,54 @@ ir_constant::ir_constant(const struct glsl_type *type,
memcpy(& this->value, data, sizeof(this->value)); memcpy(& this->value, data, sizeof(this->value));
} }
ir_constant::ir_constant(float f) ir_constant::ir_constant(float f, unsigned vector_elements)
{ {
assert(vector_elements <= 4);
this->ir_type = ir_type_constant; this->ir_type = ir_type_constant;
this->type = glsl_type::float_type; this->type = glsl_type::get_instance(GLSL_TYPE_FLOAT, vector_elements, 1);
this->value.f[0] = f; for (unsigned i = 0; i < vector_elements; i++) {
for (int i = 1; i < 16; i++) { this->value.f[i] = f;
}
for (unsigned i = vector_elements; i < 16; i++) {
this->value.f[i] = 0; this->value.f[i] = 0;
} }
} }
ir_constant::ir_constant(unsigned int u) ir_constant::ir_constant(unsigned int u, unsigned vector_elements)
{ {
assert(vector_elements <= 4);
this->ir_type = ir_type_constant; this->ir_type = ir_type_constant;
this->type = glsl_type::uint_type; this->type = glsl_type::get_instance(GLSL_TYPE_UINT, vector_elements, 1);
this->value.u[0] = u; for (unsigned i = 0; i < vector_elements; i++) {
for (int i = 1; i < 16; i++) { this->value.u[i] = u;
}
for (unsigned i = vector_elements; i < 16; i++) {
this->value.u[i] = 0; this->value.u[i] = 0;
} }
} }
ir_constant::ir_constant(int i) ir_constant::ir_constant(int integer, unsigned vector_elements)
{ {
assert(vector_elements <= 4);
this->ir_type = ir_type_constant; this->ir_type = ir_type_constant;
this->type = glsl_type::int_type; this->type = glsl_type::get_instance(GLSL_TYPE_INT, vector_elements, 1);
this->value.i[0] = i; for (unsigned i = 0; i < vector_elements; i++) {
for (int i = 1; i < 16; i++) { this->value.i[i] = integer;
}
for (unsigned i = vector_elements; i < 16; i++) {
this->value.i[i] = 0; this->value.i[i] = 0;
} }
} }
ir_constant::ir_constant(bool b) ir_constant::ir_constant(bool b, unsigned vector_elements)
{ {
assert(vector_elements <= 4);
this->ir_type = ir_type_constant; this->ir_type = ir_type_constant;
this->type = glsl_type::bool_type; this->type = glsl_type::get_instance(GLSL_TYPE_BOOL, vector_elements, 1);
this->value.b[0] = b; for (unsigned i = 0; i < vector_elements; i++) {
for (int i = 1; i < 16; i++) { this->value.b[i] = b;
}
for (unsigned i = vector_elements; i < 16; i++) {
this->value.b[i] = false; this->value.b[i] = false;
} }
} }

View File

@@ -1922,10 +1922,10 @@ union ir_constant_data {
class ir_constant : public ir_rvalue { class ir_constant : public ir_rvalue {
public: public:
ir_constant(const struct glsl_type *type, const ir_constant_data *data); ir_constant(const struct glsl_type *type, const ir_constant_data *data);
ir_constant(bool b); ir_constant(bool b, unsigned vector_elements=1);
ir_constant(unsigned int u); ir_constant(unsigned int u, unsigned vector_elements=1);
ir_constant(int i); ir_constant(int i, unsigned vector_elements=1);
ir_constant(float f); ir_constant(float f, unsigned vector_elements=1);
/** /**
* Construct an ir_constant from a list of ir_constant values * Construct an ir_constant from a list of ir_constant values