From 548d919bd32ca14ade8911ef0a3992104dfb96e8 Mon Sep 17 00:00:00 2001 From: Karol Herbst Date: Tue, 23 Jan 2024 17:02:35 +0100 Subject: [PATCH] nak: simplify phi_dsts clippy complained that nothing was actually looping here. Luckily we can simplify the code. Part-of: --- src/nouveau/compiler/nak/ir.rs | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/nouveau/compiler/nak/ir.rs b/src/nouveau/compiler/nak/ir.rs index f5acf092f08..7ff57976f07 100644 --- a/src/nouveau/compiler/nak/ir.rs +++ b/src/nouveau/compiler/nak/ir.rs @@ -5488,22 +5488,16 @@ impl BasicBlock { } pub fn phi_dsts(&self) -> Option<&OpPhiDsts> { - for instr in self.instrs.iter() { - match &instr.op { - Op::PhiDsts(phi) => return Some(phi), - _ => break, - } + if let Op::PhiDsts(phi) = &self.instrs.first()?.op { + return Some(phi); } None } #[allow(dead_code)] pub fn phi_dsts_mut(&mut self) -> Option<&mut OpPhiDsts> { - for instr in self.instrs.iter_mut() { - match &mut instr.op { - Op::PhiDsts(phi) => return Some(phi), - _ => break, - } + if let Op::PhiDsts(phi) = &mut self.instrs.first_mut()?.op { + return Some(phi); } None }