OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel/blorp: Allow gfx12 fast-clears without CCS surf

Browse Source 
I'd like to phase out the ISL surface representation of CCS on gfx120 in
order to enable CCS without a 512B-aligned main surface pitch. Remove
the dependency on CCS ISL surfaces when fast-clearing to move drivers
one step towards that goal.

Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28536>
This commit is contained in:
Nanley Chery
2024-04-02 17:26:26 -04:00
committed by Marge Bot
parent 18326211c3
commit 53e77cef36
1 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/intel/blorp/blorp_clear.c
View File

@@ -255,7 +255,6 @@ get_fast_clear_rect(const struct isl_device *dev,
unreachable("Unsupported tiling format");
}
} else {
assert(aux_surf->usage == ISL_SURF_USAGE_CCS_BIT);
/* From the Ivy Bridge PRM, Vol2 Part1 11.7 "MCS Buffer for Render
* Target(s)", beneath the "Fast Color Clear" bullet (p327):
*
@@ -270,9 +269,25 @@ get_fast_clear_rect(const struct isl_device *dev,
* The alignment size in the table that follows is a multiple of the
* alignment size that is baked into the CCS surface format.
*/
x_align = isl_format_get_layout(aux_surf->format)->bw * 16;
y_align = isl_format_get_layout(aux_surf->format)->bh * 32 /
isl_format_get_layout(aux_surf->format)->bpb;
enum isl_format ccs_format;
if (ISL_GFX_VERX10(dev) == 120) {
assert(surf->tiling == ISL_TILING_Y0);
switch (isl_format_get_layout(surf->format)->bpb) {
case 8: ccs_format = ISL_FORMAT_GFX12_CCS_8BPP_Y0; break;
case 16: ccs_format = ISL_FORMAT_GFX12_CCS_16BPP_Y0; break;
case 32: ccs_format = ISL_FORMAT_GFX12_CCS_32BPP_Y0; break;
case 64: ccs_format = ISL_FORMAT_GFX12_CCS_64BPP_Y0; break;
case 128: ccs_format = ISL_FORMAT_GFX12_CCS_128BPP_Y0; break;
default: unreachable("Invalid surface bpb for fast clearing");
}
} else {
assert(aux_surf->usage == ISL_SURF_USAGE_CCS_BIT);
ccs_format = aux_surf->format;
}
x_align = isl_format_get_layout(ccs_format)->bw * 16;
y_align = isl_format_get_layout(ccs_format)->bh * 32 /
isl_format_get_layout(ccs_format)->bpb;
/* From the Ivy Bridge PRM, Vol2 Part1 11.7 "MCS Buffer for Render
* Target(s)", beneath the "Fast Color Clear" bullet (p327):