OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glsl: Disallow unsized array of atomic_uint

Browse Source 
This was a bugfix to the spec addressed in OpenGL 4.5 (revision
7 of the spec) and there is a CTS test to check this.

Fixes:
KHR-GL45.shader_atomic_counters.negative-unsized-array

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
This commit is contained in:
Iago Toral Quiroga
2017-09-11 14:19:41 +02:00
parent ea314bf812
commit 51bf007d2c
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/compiler/glsl/ast_to_hir.cpp
View File

@@ -5542,6 +5542,17 @@ ast_declarator_list::hir(exec_list *instructions,
"GLSL ES"); "GLSL ES");
} }
/* Section 4.4.6.1 Atomic Counter Layout Qualifiers of the GLSL 4.60 spec:
*
* "It is a compile-time error to declare an unsized array of
* atomic_uint"
*/
if (var->type->is_unsized_array() &&
var->type->without_array()->base_type == GLSL_TYPE_ATOMIC_UINT) {
_mesa_glsl_error(& loc, state,
"Unsized array of atomic_uint is not allowed");
}
/* If the declaration is not a redeclaration, there are a few additional /* If the declaration is not a redeclaration, there are a few additional
* semantic checks that must be applied. In addition, variable that was * semantic checks that must be applied. In addition, variable that was
* created for the declaration should be added to the IR stream. * created for the declaration should be added to the IR stream.