OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel/eu/validate: Check predication and cmod for SEL, CMP, and CMPN

Browse Source 
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20527>
This commit is contained in:
Ian Romanick
2023-01-06 16:53:18 -08:00
committed by Marge Bot
parent e0f409c5d8
commit 51be623372
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/intel/compiler/brw_eu_validate.c
View File

@@ -2076,6 +2076,22 @@ instruction_restrictions(const struct brw_isa_info *isa,
"If the destination is the null register, the {Switch} "
"instruction option must be used.");
}
ERROR_IF(brw_inst_cond_modifier(devinfo, inst) == BRW_CONDITIONAL_NONE,
"CMP (or CMPN) must have a condition.");
}
if (brw_inst_opcode(isa, inst) == BRW_OPCODE_SEL) {
if (devinfo->ver < 6) {
ERROR_IF(brw_inst_cond_modifier(devinfo, inst) != BRW_CONDITIONAL_NONE,
"SEL must not have a condition modifier");
ERROR_IF(brw_inst_pred_control(devinfo, inst) == BRW_PREDICATE_NONE,
"SEL must be predicated");
} else {
ERROR_IF((brw_inst_cond_modifier(devinfo, inst) != BRW_CONDITIONAL_NONE) ==
(brw_inst_pred_control(devinfo, inst) != BRW_PREDICATE_NONE),
"SEL must either be predicated or have a condition modifiers");
}
}
if (brw_inst_opcode(isa, inst) == BRW_OPCODE_MUL) {