ac: change ac_query_gpu_info() signature
Currently libdrm_amdgpu provides a typedef of the various handles. While the goal was to make those opaque, it effectively became part of the API To the best of my knowledge there are two ways to have opaque handles: - "typedef void *foo;" - rather messy IMHO - "stuct foo;" and use "struct foo *" through the API In our case amdgpu_device_handle is used only internally, plus respective code is not used or applicable for r300 and r600. Hence we copied the typedef. Seemingly this will be a problem since libdrm_amdgpu wants to change the API, while not updating the code(?). Either way, we can safely s/amdgpU_device_handle/void */ and carry on. Cc: Michel Dänzer <michel@daenzer.net> Signed-off-by: Emil Velikov <emil.velikov@collabora.com> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
This commit is contained in:

committed by
Emil Velikov

parent
7c745f6148
commit
4ec32413f3
@@ -35,8 +35,6 @@
|
||||
extern "C" {
|
||||
#endif
|
||||
|
||||
/* Prior to C11 the following may trigger a typedef redeclaration warning */
|
||||
typedef struct amdgpu_device *amdgpu_device_handle;
|
||||
struct amdgpu_gpu_info;
|
||||
|
||||
struct radeon_info {
|
||||
@@ -151,7 +149,7 @@ struct radeon_info {
|
||||
uint32_t cik_macrotile_mode_array[16];
|
||||
};
|
||||
|
||||
bool ac_query_gpu_info(int fd, amdgpu_device_handle dev,
|
||||
bool ac_query_gpu_info(int fd, void *dev_p,
|
||||
struct radeon_info *info,
|
||||
struct amdgpu_gpu_info *amdinfo);
|
||||
|
||||
|
Reference in New Issue
Block a user