llvmpipe: fix debug print iterating in set_framebuffer_state

this would potentially access garbage memory by checking the existing
state using the incoming state's iterator values

cc: mesa-stable

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14857>
This commit is contained in:
Mike Blumenkrantz
2022-01-28 09:46:47 -05:00
committed by Marge Bot
parent 3ef093f697
commit 4c76a19ca3

View File

@@ -67,13 +67,13 @@ llvmpipe_set_framebuffer_state(struct pipe_context *pipe,
const struct util_format_description *depth_desc =
util_format_description(depth_format);
if (lp->framebuffer.zsbuf && lp->framebuffer.zsbuf->context != pipe) {
if (fb->zsbuf && fb->zsbuf->context != pipe) {
debug_printf("Illegal setting of fb state with zsbuf created in "
"another context\n");
}
for (i = 0; i < fb->nr_cbufs; i++) {
if (lp->framebuffer.cbufs[i] &&
lp->framebuffer.cbufs[i]->context != pipe) {
if (fb->cbufs[i] &&
fb->cbufs[i]->context != pipe) {
debug_printf("Illegal setting of fb state with cbuf %d created in "
"another context\n", i);
}