OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadcom/compiler: add a definition for the unifa skip distance

Browse Source 
We will be using this distance to setup another optimization in a
follow-up patch.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>

x# Please enter the commit message for your changes. Lines starting

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10100>
This commit is contained in:
Iago Toral Quiroga
2021-04-08 09:02:16 +02:00
committed by Marge Bot
parent a45ab46563
commit 4b244dc64f
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/broadcom/compiler/nir_to_vir.c
View File

@@ -2644,6 +2644,12 @@ emit_ldunifa(struct v3d_compile *c, struct qreg *result)
static void static void
ntq_emit_load_ubo_unifa(struct v3d_compile *c, nir_intrinsic_instr *instr) ntq_emit_load_ubo_unifa(struct v3d_compile *c, nir_intrinsic_instr *instr)
{ {
/* Every ldunifa auto-increments the unifa address by 4 bytes, so our
* last unifa offset is 4 bytes ahead of the offset of the last load.
*/
static const int32_t max_unifa_skip_dist =
MAX_UNIFA_SKIP_DISTANCE - 4;
bool dynamic_src = !nir_src_is_const(instr->src[1]); bool dynamic_src = !nir_src_is_const(instr->src[1]);
uint32_t const_offset = uint32_t const_offset =
dynamic_src ? 0 : nir_src_as_uint(instr->src[1]); dynamic_src ? 0 : nir_src_as_uint(instr->src[1]);
@@ -2656,7 +2662,10 @@ ntq_emit_load_ubo_unifa(struct v3d_compile *c, nir_intrinsic_instr *instr)
index++; index++;
/* We can only keep track of the last unifa address we used with /* We can only keep track of the last unifa address we used with
* constant offset loads. * constant offset loads. If the new load targets the same UBO and
* is close enough to the previous load, we can skip the unifa register
* write by emitting dummy ldunifa instructions to update the unifa
* address.
*/ */
bool skip_unifa = false; bool skip_unifa = false;
uint32_t ldunifa_skips = 0; uint32_t ldunifa_skips = 0;
@@ -2665,7 +2674,7 @@ ntq_emit_load_ubo_unifa(struct v3d_compile *c, nir_intrinsic_instr *instr)
} else if (c->cur_block == c->last_unifa_block && } else if (c->cur_block == c->last_unifa_block &&
c->last_unifa_index == index && c->last_unifa_index == index &&
c->last_unifa_offset <= const_offset && c->last_unifa_offset <= const_offset &&
c->last_unifa_offset + 12 >= const_offset) { c->last_unifa_offset + max_unifa_skip_dist >= const_offset) {
skip_unifa = true; skip_unifa = true;
ldunifa_skips = (const_offset - c->last_unifa_offset) / 4; ldunifa_skips = (const_offset - c->last_unifa_offset) / 4;
} else { } else {

7
src/broadcom/compiler/v3d_compiler.h
View File

@@ -61,6 +61,13 @@
*/ */
#define MAX_TMU_QUEUE_SIZE 8 #define MAX_TMU_QUEUE_SIZE 8
/**
* Maximum offset distance in bytes between two consecutive constant UBO loads
* for the same UBO where we would favor updating the unifa address by emitting
* dummy ldunifa instructions to avoid writing the unifa register.
*/
#define MAX_UNIFA_SKIP_DISTANCE 16
struct nir_builder; struct nir_builder;
struct v3d_fs_inputs { struct v3d_fs_inputs {