nir: use nir_shader_instructions_pass in nir_lower_bool_to_bitsize

Changes:
- nir_metadata_preserve(..., nir_metadata_all) is called when pass doesn't
  make progress

Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12282>
This commit is contained in:
Marcin Ślusarz
2021-08-09 13:45:27 +02:00
committed by Marge Bot
parent 5beeb3c1db
commit 4a9e2dc1e9

View File

@@ -402,61 +402,41 @@ lower_tex_instr(nir_tex_instr *tex)
} }
static bool static bool
nir_lower_bool_to_bitsize_impl(nir_builder *b, nir_function_impl *impl) nir_lower_bool_to_bitsize_instr(nir_builder *b,
nir_instr *instr,
UNUSED void *cb_data)
{ {
bool progress = false; switch (instr->type) {
case nir_instr_type_alu:
return lower_alu_instr(b, nir_instr_as_alu(instr));
nir_foreach_block(block, impl) { case nir_instr_type_load_const:
nir_foreach_instr_safe(instr, block) { return lower_load_const_instr(nir_instr_as_load_const(instr));
switch (instr->type) {
case nir_instr_type_alu:
progress |= lower_alu_instr(b, nir_instr_as_alu(instr));
break;
case nir_instr_type_load_const: case nir_instr_type_phi:
progress |= lower_load_const_instr(nir_instr_as_load_const(instr)); return lower_phi_instr(b, nir_instr_as_phi(instr));
break;
case nir_instr_type_phi: case nir_instr_type_ssa_undef:
progress |= lower_phi_instr(b, nir_instr_as_phi(instr)); case nir_instr_type_intrinsic: {
break; bool progress = false;
nir_foreach_ssa_def(instr, rewrite_1bit_ssa_def_to_32bit, &progress);
case nir_instr_type_ssa_undef: return progress;
case nir_instr_type_intrinsic:
nir_foreach_ssa_def(instr, rewrite_1bit_ssa_def_to_32bit,
&progress);
break;
case nir_instr_type_tex:
progress |= lower_tex_instr(nir_instr_as_tex(instr));
break;
default:
nir_foreach_ssa_def(instr, assert_ssa_def_is_not_1bit, NULL);
}
}
} }
if (progress) { case nir_instr_type_tex:
nir_metadata_preserve(impl, nir_metadata_block_index | return lower_tex_instr(nir_instr_as_tex(instr));
nir_metadata_dominance);
}
return progress; default:
nir_foreach_ssa_def(instr, assert_ssa_def_is_not_1bit, NULL);
return false;
}
} }
bool bool
nir_lower_bool_to_bitsize(nir_shader *shader) nir_lower_bool_to_bitsize(nir_shader *shader)
{ {
nir_builder b; return nir_shader_instructions_pass(shader, nir_lower_bool_to_bitsize_instr,
bool progress = false; nir_metadata_block_index |
nir_metadata_dominance,
nir_foreach_function(function, shader) { NULL);
if (function->impl) {
nir_builder_init(&b, function->impl);
progress = nir_lower_bool_to_bitsize_impl(&b, function->impl) || progress;
}
}
return progress;
} }