OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

agx: Forcibly vectorize pointcoord coeffs

Browse Source 
This avoids regressions from scalarizing pointcoord loads.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24498>
This commit is contained in:
Alyssa Rosenzweig
2023-08-04 11:38:31 -04:00
committed by Marge Bot
parent 52b8d31548
commit 48029548f3
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/asahi/compiler/agx_compile.c
View File

@@ -91,6 +91,18 @@ agx_get_cf(agx_context *ctx, bool smooth, bool perspective,
varyings->reads_z |= (offset == 2); varyings->reads_z |= (offset == 2);
} }
/* Forcibly vectorize pointcoord reads, since there's no (known) way to index
* Y alone.
*/
bool is_pntc = (slot == VARYING_SLOT_PNTC);
unsigned cf_offset = 0;
if (is_pntc) {
cf_offset = offset;
offset = 0;
count = MAX2(2, count + offset);
}
/* First, search for an appropriate binding. This is O(n) to the number of /* First, search for an appropriate binding. This is O(n) to the number of
* bindings, which isn't great, but n should be small in practice. * bindings, which isn't great, but n should be small in practice.
*/ */
@@ -101,7 +113,7 @@ agx_get_cf(agx_context *ctx, bool smooth, bool perspective,
(varyings->bindings[b].smooth == smooth) && (varyings->bindings[b].smooth == smooth) &&
(varyings->bindings[b].perspective == perspective)) { (varyings->bindings[b].perspective == perspective)) {
return agx_immediate(varyings->bindings[b].cf_base); return agx_immediate(varyings->bindings[b].cf_base + cf_offset);
} }
} }
@@ -115,7 +127,7 @@ agx_get_cf(agx_context *ctx, bool smooth, bool perspective,
varyings->bindings[b].perspective = perspective; varyings->bindings[b].perspective = perspective;
varyings->nr_cf += count; varyings->nr_cf += count;
return agx_immediate(cf_base); return agx_immediate(cf_base + cf_offset);
} }
/* Builds a 64-bit hash table key for an index */ /* Builds a 64-bit hash table key for an index */