OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gfxstream: always advertise device memory extension guest side

Browse Source 
memory report extension is present.  It's is filtered out when
sent host side, since for a virtual GPU this is quite difficult
to implement.

Mesa runtime is picky about physical device features.  So if
the test tries to enable device level extension without it
definitely existing, the test will fail.

The test can also be modified to check
VkPhysicalDeviceDeviceMemoryReportFeaturesEXT, but that's more
involved.  Work around this by always advertising the extension.

Reviewed-by: Aaron Ruby <aruby@blackberry.com>
Acked-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27246>
This commit is contained in:
Gurchetan Singh
2024-04-29 18:07:14 -07:00
committed by Marge Bot
parent 4a95b71975
commit 47b0536ba2
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/gfxstream/guest/vulkan_enc/ResourceTracker.cpp
View File

@@ -1824,6 +1824,20 @@ VkResult ResourceTracker::on_vkEnumerateDeviceExtensionProperties(
filteredExts.push_back(anbExtProp); filteredExts.push_back(anbExtProp);
} }
/*
* GfxstreamEnd2EndVkTest::DeviceMemoryReport always assumes the memory report
* extension is present. It's is filtered out when sent host side, since for a
* virtual GPU this is quite difficult to implement.
*
* Mesa runtime checks physical device features. So if the test tries to enable
* device level extension without it definitely existing, the test will fail.
*
* The test can also be modified to check VkPhysicalDeviceDeviceMemoryReportFeaturesEXT,
* but that's more involved. Work around this by always advertising the extension.
* Tracking bug: b/338270042
*/
filteredExts.push_back(VkExtensionProperties{"VK_EXT_device_memory_report", 1});
#if defined(VK_USE_PLATFORM_ANDROID_KHR) || defined(__linux__) #if defined(VK_USE_PLATFORM_ANDROID_KHR) || defined(__linux__)
bool hostSupportsExternalFenceFd = bool hostSupportsExternalFenceFd =
getHostDeviceExtensionIndex("VK_KHR_external_fence_fd") != -1; getHostDeviceExtensionIndex("VK_KHR_external_fence_fd") != -1;