From 459f18b866f14619233ed9f119ee208a44697555 Mon Sep 17 00:00:00 2001 From: Sid Pranjale Date: Wed, 18 Oct 2023 01:42:38 +0530 Subject: [PATCH] nvk: Enable VK_EXT_load_store_op_none VK_ATTACHMENT_STORE_OP_NONE_EXT is already supported via VK_KHR_dynamic_rendering, logic dictates it shouldn't need much else for VK_ATTACHMENT_LOAD_OP_NONE_EXT. CTS is passing with the following results on dEQP-VK.renderpass*.load_store_op_none.* tests Test run totals: Passed: 78/110 (70.9%) Failed: 0/110 (0.0%) Not supported: 32/110 (29.1%) Warnings: 0/110 (0.0%) Waived: 0/110 (0.0%) Requires !24596 to achieve parity with proprietary driver Closes #9638 Signed-off-by: Sid Pranjale Part-of: --- docs/features.txt | 2 +- src/nouveau/vulkan/nvk_physical_device.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 4cd7c05f28f..f72b0be82ce 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -578,7 +578,7 @@ Khronos extensions that are not part of any Vulkan version: VK_EXT_image_view_min_lod DONE (anv, hasvk, nvk, radv, tu, vn) VK_EXT_index_type_uint8 DONE (anv, hasvk, nvk, lvp, panvk, radv/gfx8+, tu, v3dv, vn) VK_EXT_line_rasterization DONE (anv, hasvk, nvk, lvp, radv, tu, v3dv, vn) - VK_EXT_load_store_op_none DONE (anv, radv, tu, v3dv, vn) + VK_EXT_load_store_op_none DONE (anv, nvk, radv, tu, v3dv, vn) VK_EXT_memory_budget DONE (anv, hasvk, lvp, radv, tu, v3dv, vn) VK_EXT_memory_priority DONE (lvp, radv) VK_EXT_mesh_shader DONE (anv/gfx12.5+, lvp, radv) diff --git a/src/nouveau/vulkan/nvk_physical_device.c b/src/nouveau/vulkan/nvk_physical_device.c index aff8a0d2296..548e32053a9 100644 --- a/src/nouveau/vulkan/nvk_physical_device.c +++ b/src/nouveau/vulkan/nvk_physical_device.c @@ -116,6 +116,7 @@ nvk_get_device_extensions(const struct nv_device_info *info, .EXT_index_type_uint8 = true, .EXT_inline_uniform_block = true, .EXT_line_rasterization = true, + .EXT_load_store_op_none = true, .EXT_mutable_descriptor_type = true, .EXT_non_seamless_cube_map = true, .EXT_pci_bus_info = info->type == NV_DEVICE_TYPE_DIS,