OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel/fs: Properly lower 64-bit MUL on 64-bit-incapable platforms

Browse Source 
There are two problems this commit solves:  First, is that the 64x64 MUL
lowering generates a Q MOV which, because of how late it runs in the
compile pipeline, it never gets removed.  Second, it generates 32x32
MULs and we have to run it a second time to lower those.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7329>
This commit is contained in:
Jason Ekstrand
2020-10-27 02:24:30 -05:00
committed by Marge Bot
parent c80db6611a
commit 44571c6a68
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/intel/compiler/brw_fs.cpp
View File

@@ -4122,7 +4122,14 @@ fs_visitor::lower_mul_qword_inst(fs_inst *inst, bblock_t *block)
ibld.ADD(subscript(bd, BRW_REGISTER_TYPE_UD, 1), ibld.ADD(subscript(bd, BRW_REGISTER_TYPE_UD, 1),
subscript(bd, BRW_REGISTER_TYPE_UD, 1), ad); subscript(bd, BRW_REGISTER_TYPE_UD, 1), ad);
ibld.MOV(inst->dst, bd); if (devinfo->has_64bit_int) {
ibld.MOV(inst->dst, bd);
} else {
ibld.MOV(subscript(inst->dst, BRW_REGISTER_TYPE_UD, 0),
subscript(bd, BRW_REGISTER_TYPE_UD, 0));
ibld.MOV(subscript(inst->dst, BRW_REGISTER_TYPE_UD, 1),
subscript(bd, BRW_REGISTER_TYPE_UD, 1));
}
} }
void void
@@ -7924,7 +7931,13 @@ fs_visitor::optimize()
} }
OPT(opt_combine_constants); OPT(opt_combine_constants);
OPT(lower_integer_multiplication); if (OPT(lower_integer_multiplication)) {
/* If lower_integer_multiplication made progress, it may have produced
* some 32x32-bit MULs in the process of lowering 64-bit MULs. Run it
* one more time to clean those up if they exist.
*/
OPT(lower_integer_multiplication);
}
OPT(lower_sub_sat); OPT(lower_sub_sat);
if (devinfo->gen <= 5 && OPT(lower_minmax)) { if (devinfo->gen <= 5 && OPT(lower_minmax)) {