nir: Switch to using 1-bit Booleans for almost everything
This is a squash of a few distinct changes: glsl,spirv: Generate 1-bit Booleans Revert "Use 32-bit opcodes in the NIR producers and optimizations" Revert "nir/builder: Generate 32-bit bool opcodes transparently" nir/builder: Generate 1-bit Booleans in nir_build_imm_bool Reviewed-by: Eric Anholt <eric@anholt.net> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Tested-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
This commit is contained in:

committed by
Jason Ekstrand

parent
11dc130779
commit
44227453ec
@@ -261,7 +261,7 @@ constant_copy(ir_constant *ir, void *mem_ctx)
|
||||
assert(cols == 1);
|
||||
|
||||
for (unsigned r = 0; r < rows; r++)
|
||||
ret->values[0].u32[r] = ir->value.b[r] ? NIR_TRUE : NIR_FALSE;
|
||||
ret->values[0].b[r] = ir->value.b[r];
|
||||
|
||||
break;
|
||||
|
||||
@@ -1000,7 +1000,8 @@ nir_visitor::visit(ir_call *ir)
|
||||
assert(write_mask);
|
||||
|
||||
nir_ssa_def *nir_val = evaluate_rvalue(val);
|
||||
assert(!val->type->is_boolean() || nir_val->bit_size == 32);
|
||||
if (val->type->is_boolean())
|
||||
nir_val = nir_b2i32(&b, nir_val);
|
||||
|
||||
instr->src[0] = nir_src_for_ssa(nir_val);
|
||||
instr->src[1] = nir_src_for_ssa(evaluate_rvalue(block));
|
||||
@@ -1110,6 +1111,10 @@ nir_visitor::visit(ir_call *ir)
|
||||
type->vector_elements, bit_size, NULL);
|
||||
|
||||
nir_builder_instr_insert(&b, &instr->instr);
|
||||
|
||||
/* The value in shared memory is a 32-bit value */
|
||||
if (type->is_boolean())
|
||||
ret = nir_i2b(&b, &instr->dest.ssa);
|
||||
break;
|
||||
}
|
||||
case nir_intrinsic_store_shared: {
|
||||
@@ -1129,7 +1134,9 @@ nir_visitor::visit(ir_call *ir)
|
||||
nir_intrinsic_set_write_mask(instr, write_mask->value.u[0]);
|
||||
|
||||
nir_ssa_def *nir_val = evaluate_rvalue(val);
|
||||
assert(!val->type->is_boolean() || nir_val->bit_size == 32);
|
||||
/* The value in shared memory is a 32-bit value */
|
||||
if (val->type->is_boolean())
|
||||
nir_val = nir_b2i32(&b, nir_val);
|
||||
|
||||
instr->src[0] = nir_src_for_ssa(nir_val);
|
||||
instr->num_components = val->type->vector_elements;
|
||||
@@ -1187,7 +1194,7 @@ nir_visitor::visit(ir_call *ir)
|
||||
case nir_intrinsic_vote_any:
|
||||
case nir_intrinsic_vote_all:
|
||||
case nir_intrinsic_vote_ieq: {
|
||||
nir_ssa_dest_init(&instr->instr, &instr->dest, 1, 32, NULL);
|
||||
nir_ssa_dest_init(&instr->instr, &instr->dest, 1, 1, NULL);
|
||||
instr->num_components = 1;
|
||||
|
||||
ir_rvalue *value = (ir_rvalue *) ir->actual_parameters.get_head();
|
||||
|
Reference in New Issue
Block a user