OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

zink: rework/improve descriptor pool overflow handling on batch reset

Browse Source 
the existing model for descriptor pools works thusly:
* allocate pool
  * when possible, reuse existing pool from overflow array
* when pool is full, append to overflow array
* on batch reset, cycle the overflow arrays to enable reuse

the problem with this is it uses two separate arrays for overflow, and these arrays
are cycled but never consolidated, leading to wasted memory allocations for whichever
array is not currently being recycled

to resolve this, make the following changes to batch resets:
* set the recycle index to whichever overflow array is smaller
* copy the elements from the smaller array to the larger array (consolidate)
* set the number of elements in the smaller array to 0

this leads to always appending to an empty array while the array containing all the
"free" pools is always the one that's available for recycled use

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19053>
This commit is contained in:
Mike Blumenkrantz
2022-10-12 10:48:14 -04:00
committed by Marge Bot
parent 340cfa1001
commit 43dcdf3365
1 changed files with 27 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/gallium/drivers/zink/zink_descriptors.c
View File

@@ -989,6 +989,29 @@ zink_batch_descriptor_deinit(struct zink_screen *screen, struct zink_batch_state
}
}
static void
consolidate_pool_alloc(struct zink_screen *screen, struct zink_descriptor_pool_multi *mpool)
{
unsigned sizes[] = {
util_dynarray_num_elements(&mpool->overflowed_pools[0], struct zink_descriptor_pool*),
util_dynarray_num_elements(&mpool->overflowed_pools[1], struct zink_descriptor_pool*),
};
if (!sizes[0] && !sizes[1])
return;
/* set idx to whichever overflow is smaller */
mpool->overflow_idx = sizes[0] > sizes[1];
if (!mpool->overflowed_pools[mpool->overflow_idx].size)
return;
if (util_dynarray_resize(&mpool->overflowed_pools[!mpool->overflow_idx], struct zink_descriptor_pool*, sizes[0] + sizes[1])) {
/* attempt to consolidate all the overflow into one array to maximize reuse */
uint8_t *src = mpool->overflowed_pools[mpool->overflow_idx].data;
uint8_t *dst = mpool->overflowed_pools[!mpool->overflow_idx].data;
memcpy(dst, src, mpool->overflowed_pools[mpool->overflow_idx].size);
mpool->overflowed_pools[!mpool->overflow_idx].size += mpool->overflowed_pools[mpool->overflow_idx].size;
mpool->overflowed_pools[mpool->overflow_idx].size = 0;
}
}
void
zink_batch_descriptor_reset(struct zink_screen *screen, struct zink_batch_state *bs)
{
@@ -998,8 +1021,8 @@ zink_batch_descriptor_reset(struct zink_screen *screen, struct zink_batch_state
struct zink_descriptor_pool_multi *mpool = mpools[j];
if (!mpool)
continue;
if (mpool->pool->set_idx)
mpool->overflow_idx = !mpool->overflow_idx;
consolidate_pool_alloc(screen, mpool);
if (mpool->pool_key->use_count)
mpool->pool->set_idx = 0;
else {
@@ -1013,8 +1036,8 @@ zink_batch_descriptor_reset(struct zink_screen *screen, struct zink_batch_state
if (bs->dd.push_pool[i].reinit_overflow) {
/* these don't match current fbfetch usage and can never be used again */
clear_multi_pool_overflow(screen, &bs->dd.push_pool[i].overflowed_pools[bs->dd.push_pool[i].overflow_idx]);
} else if (bs->dd.push_pool[i].pool && bs->dd.push_pool[i].pool->set_idx) {
bs->dd.push_pool[i].overflow_idx = !bs->dd.push_pool[i].overflow_idx;
} else if (bs->dd.push_pool[i].pool) {
consolidate_pool_alloc(screen, &bs->dd.push_pool[i]);
}
if (bs->dd.push_pool[i].pool)
bs->dd.push_pool[i].pool->set_idx = 0;