nir: rename nir_var_ubo to nir_var_mem_ubo

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Acked-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
This commit is contained in:
Karol Herbst
2019-01-16 00:09:27 +01:00
parent 9b24028426
commit 3afc1e068f
10 changed files with 14 additions and 14 deletions

View File

@@ -367,7 +367,7 @@ nir_visitor::visit(ir_variable *ir)
case ir_var_uniform: case ir_var_uniform:
if (ir->get_interface_type()) if (ir->get_interface_type())
var->data.mode = nir_var_ubo; var->data.mode = nir_var_mem_ubo;
else else
var->data.mode = nir_var_uniform; var->data.mode = nir_var_uniform;
break; break;

View File

@@ -142,7 +142,7 @@ nir_shader_add_variable(nir_shader *shader, nir_variable *var)
break; break;
case nir_var_uniform: case nir_var_uniform:
case nir_var_ubo: case nir_var_mem_ubo:
case nir_var_ssbo: case nir_var_ssbo:
exec_list_push_tail(&shader->uniforms, &var->node); exec_list_push_tail(&shader->uniforms, &var->node);
break; break;

View File

@@ -100,7 +100,7 @@ typedef enum {
nir_var_shader_temp = (1 << 2), nir_var_shader_temp = (1 << 2),
nir_var_function_temp = (1 << 3), nir_var_function_temp = (1 << 3),
nir_var_uniform = (1 << 4), nir_var_uniform = (1 << 4),
nir_var_ubo = (1 << 5), nir_var_mem_ubo = (1 << 5),
nir_var_system_value = (1 << 6), nir_var_system_value = (1 << 6),
nir_var_ssbo = (1 << 7), nir_var_ssbo = (1 << 7),
nir_var_shared = (1 << 8), nir_var_shared = (1 << 8),

View File

@@ -54,7 +54,7 @@ nir_assign_var_locations(struct exec_list *var_list, unsigned *size,
* UBOs have their own address spaces, so don't count them towards the * UBOs have their own address spaces, so don't count them towards the
* number of global uniforms * number of global uniforms
*/ */
if (var->data.mode == nir_var_ubo || var->data.mode == nir_var_ssbo) if (var->data.mode == nir_var_mem_ubo || var->data.mode == nir_var_ssbo)
continue; continue;
var->data.driver_location = location; var->data.driver_location = location;
@@ -587,7 +587,7 @@ build_explicit_io_load(nir_builder *b, nir_intrinsic_instr *intrin,
nir_intrinsic_op op; nir_intrinsic_op op;
switch (mode) { switch (mode) {
case nir_var_ubo: case nir_var_mem_ubo:
op = nir_intrinsic_load_ubo; op = nir_intrinsic_load_ubo;
break; break;
case nir_var_ssbo: case nir_var_ssbo:
@@ -602,7 +602,7 @@ build_explicit_io_load(nir_builder *b, nir_intrinsic_instr *intrin,
load->src[0] = nir_src_for_ssa(addr_to_index(b, addr, addr_format)); load->src[0] = nir_src_for_ssa(addr_to_index(b, addr, addr_format));
load->src[1] = nir_src_for_ssa(addr_to_offset(b, addr, addr_format)); load->src[1] = nir_src_for_ssa(addr_to_offset(b, addr, addr_format));
if (mode != nir_var_ubo) if (mode != nir_var_mem_ubo)
nir_intrinsic_set_access(load, nir_intrinsic_access(intrin)); nir_intrinsic_set_access(load, nir_intrinsic_access(intrin));
/* TODO: We should try and provide a better alignment. For OpenCL, we need /* TODO: We should try and provide a better alignment. For OpenCL, we need

View File

@@ -413,7 +413,7 @@ get_variable_mode_str(nir_variable_mode mode, bool want_local_global_mode)
return "shader_out"; return "shader_out";
case nir_var_uniform: case nir_var_uniform:
return "uniform"; return "uniform";
case nir_var_ubo: case nir_var_mem_ubo:
return "ubo"; return "ubo";
case nir_var_system_value: case nir_var_system_value:
return "system"; return "system";
@@ -506,7 +506,7 @@ print_var_decl(nir_variable *var, print_state *state)
if (var->data.mode == nir_var_shader_in || if (var->data.mode == nir_var_shader_in ||
var->data.mode == nir_var_shader_out || var->data.mode == nir_var_shader_out ||
var->data.mode == nir_var_uniform || var->data.mode == nir_var_uniform ||
var->data.mode == nir_var_ubo || var->data.mode == nir_var_mem_ubo ||
var->data.mode == nir_var_ssbo) { var->data.mode == nir_var_ssbo) {
const char *loc = NULL; const char *loc = NULL;
char buf[4]; char buf[4];

View File

@@ -446,7 +446,7 @@ validate_deref_instr(nir_deref_instr *instr, validate_state *state)
case nir_deref_type_array: case nir_deref_type_array:
case nir_deref_type_array_wildcard: case nir_deref_type_array_wildcard:
if (instr->mode == nir_var_ubo || if (instr->mode == nir_var_mem_ubo ||
instr->mode == nir_var_ssbo || instr->mode == nir_var_ssbo ||
instr->mode == nir_var_shared) { instr->mode == nir_var_shared) {
/* Shared variables and UBO/SSBOs have a bit more relaxed rules /* Shared variables and UBO/SSBOs have a bit more relaxed rules

View File

@@ -259,7 +259,7 @@ vtn_nir_deref_pointer_dereference(struct vtn_builder *b,
assert(base->mode == vtn_variable_mode_ssbo || assert(base->mode == vtn_variable_mode_ssbo ||
base->mode == vtn_variable_mode_ubo); base->mode == vtn_variable_mode_ubo);
nir_variable_mode nir_mode = nir_variable_mode nir_mode =
base->mode == vtn_variable_mode_ssbo ? nir_var_ssbo : nir_var_ubo; base->mode == vtn_variable_mode_ssbo ? nir_var_ssbo : nir_var_mem_ubo;
tail = nir_build_deref_cast(&b->nb, desc, nir_mode, type->type, tail = nir_build_deref_cast(&b->nb, desc, nir_mode, type->type,
base->ptr_type->stride); base->ptr_type->stride);
@@ -1662,7 +1662,7 @@ vtn_storage_class_to_mode(struct vtn_builder *b,
case SpvStorageClassUniform: case SpvStorageClassUniform:
if (interface_type->block) { if (interface_type->block) {
mode = vtn_variable_mode_ubo; mode = vtn_variable_mode_ubo;
nir_mode = nir_var_ubo; nir_mode = nir_var_mem_ubo;
} else if (interface_type->buffer_block) { } else if (interface_type->buffer_block) {
mode = vtn_variable_mode_ssbo; mode = vtn_variable_mode_ssbo;
nir_mode = nir_var_ssbo; nir_mode = nir_var_ssbo;

View File

@@ -677,7 +677,7 @@ void si_nir_scan_shader(const struct nir_shader *nir,
*/ */
if (variable->interface_type != NULL) { if (variable->interface_type != NULL) {
if (variable->data.mode == nir_var_uniform || if (variable->data.mode == nir_var_uniform ||
variable->data.mode == nir_var_ubo) { variable->data.mode == nir_var_mem_ubo) {
unsigned block_count; unsigned block_count;
if (base_type != GLSL_TYPE_INTERFACE) { if (base_type != GLSL_TYPE_INTERFACE) {

View File

@@ -211,7 +211,7 @@ anv_shader_compile_to_nir(struct anv_device *device,
NIR_PASS_V(nir, nir_remove_dead_variables, NIR_PASS_V(nir, nir_remove_dead_variables,
nir_var_shader_in | nir_var_shader_out | nir_var_system_value); nir_var_shader_in | nir_var_shader_out | nir_var_system_value);
NIR_PASS_V(nir, nir_lower_explicit_io, nir_var_ubo | nir_var_ssbo, NIR_PASS_V(nir, nir_lower_explicit_io, nir_var_mem_ubo | nir_var_ssbo,
nir_address_format_vk_index_offset); nir_address_format_vk_index_offset);
NIR_PASS_V(nir, nir_propagate_invariant); NIR_PASS_V(nir, nir_propagate_invariant);

View File

@@ -253,7 +253,7 @@ st_nir_assign_uniform_locations(struct gl_context *ctx,
* UBO's have their own address spaces, so don't count them towards the * UBO's have their own address spaces, so don't count them towards the
* number of global uniforms * number of global uniforms
*/ */
if (uniform->data.mode == nir_var_ubo || uniform->data.mode == nir_var_ssbo) if (uniform->data.mode == nir_var_mem_ubo || uniform->data.mode == nir_var_ssbo)
continue; continue;
const struct glsl_type *type = glsl_without_array(uniform->type); const struct glsl_type *type = glsl_without_array(uniform->type);