glsl: Refactor is_vec_{zero,one} to be methods of ir_constant

These predicates will be used in other places soon.
This commit is contained in:
Ian Romanick
2010-11-12 10:19:08 -08:00
parent 4f84a3aa32
commit 38e55153af
3 changed files with 101 additions and 68 deletions

View File

@@ -742,6 +742,79 @@ ir_constant::has_value(const ir_constant *c) const
return true;
}
bool
ir_constant::is_zero() const
{
if (!this->type->is_scalar() && !this->type->is_vector())
return false;
for (unsigned c = 0; c < this->type->vector_elements; c++) {
switch (this->type->base_type) {
case GLSL_TYPE_FLOAT:
if (this->value.f[c] != 0.0)
return false;
break;
case GLSL_TYPE_INT:
if (this->value.i[c] != 0)
return false;
break;
case GLSL_TYPE_UINT:
if (this->value.u[c] != 0)
return false;
break;
case GLSL_TYPE_BOOL:
if (this->value.b[c] != false)
return false;
break;
default:
/* The only other base types are structures, arrays, and samplers.
* Samplers cannot be constants, and the others should have been
* filtered out above.
*/
assert(!"Should not get here.");
return false;
}
}
return true;
}
bool
ir_constant::is_one() const
{
if (!this->type->is_scalar() && !this->type->is_vector())
return false;
for (unsigned c = 0; c < this->type->vector_elements; c++) {
switch (this->type->base_type) {
case GLSL_TYPE_FLOAT:
if (this->value.f[c] != 1.0)
return false;
break;
case GLSL_TYPE_INT:
if (this->value.i[c] != 1)
return false;
break;
case GLSL_TYPE_UINT:
if (this->value.u[c] != 1)
return false;
break;
case GLSL_TYPE_BOOL:
if (this->value.b[c] != true)
return false;
break;
default:
/* The only other base types are structures, arrays, and samplers.
* Samplers cannot be constants, and the others should have been
* filtered out above.
*/
assert(!"Should not get here.");
return false;
}
}
return true;
}
ir_loop::ir_loop()
{

View File

@@ -1441,9 +1441,33 @@ public:
/**
* Determine whether a constant has the same value as another constant
*
* \sa ir_constant::is_zero, ir_constant::is_one
*/
bool has_value(const ir_constant *) const;
/**
* Determine if a constant has the value zero
*
* \note
* This function always returns \c false for constants that are not
* scalars or vectors.
*
* \sa ir_constant::has_value, ir_constant::is_one
*/
bool is_zero() const;
/**
* Determine if a constant has the value one
*
* \note
* This function always returns \c false for constants that are not
* scalars or vectors.
*
* \sa ir_constant::has_value, ir_constant::is_zero
*/
bool is_one() const;
/**
* Value of the constant.
*

View File

@@ -68,80 +68,16 @@ public:
bool progress;
};
static bool
static inline bool
is_vec_zero(ir_constant *ir)
{
int c;
if (!ir)
return false;
if (!ir->type->is_scalar() &&
!ir->type->is_vector())
return false;
for (c = 0; c < ir->type->vector_elements; c++) {
switch (ir->type->base_type) {
case GLSL_TYPE_FLOAT:
if (ir->value.f[c] != 0.0)
return false;
break;
case GLSL_TYPE_INT:
if (ir->value.i[c] != 0)
return false;
break;
case GLSL_TYPE_UINT:
if (ir->value.u[c] != 0)
return false;
break;
case GLSL_TYPE_BOOL:
if (ir->value.b[c] != false)
return false;
break;
default:
assert(!"bad base type");
return false;
}
}
return true;
return (ir == NULL) ? false : ir->is_zero();
}
static bool
static inline bool
is_vec_one(ir_constant *ir)
{
int c;
if (!ir)
return false;
if (!ir->type->is_scalar() &&
!ir->type->is_vector())
return false;
for (c = 0; c < ir->type->vector_elements; c++) {
switch (ir->type->base_type) {
case GLSL_TYPE_FLOAT:
if (ir->value.f[c] != 1.0)
return false;
break;
case GLSL_TYPE_INT:
if (ir->value.i[c] != 1)
return false;
break;
case GLSL_TYPE_UINT:
if (ir->value.u[c] != 1)
return false;
break;
case GLSL_TYPE_BOOL:
if (ir->value.b[c] != true)
return false;
break;
default:
assert(!"bad base type");
return false;
}
}
return true;
return (ir == NULL) ? false : ir->is_one();
}
static void