OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glsl: Fix assertion checking types of constant bitshift expressions.

Browse Source 
Bitshifts are one of the rare places that GLSL allows mixed base types
without an implicit conversion occurring.

Reviewed-by: Chad Versace <chad@chad-versace.us>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
This commit is contained in:
Eric Anholt
2011-09-27 14:27:58 -07:00
parent 1d59de1456
commit 344f94bb00
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/glsl/ir_constant_expression.cpp
View File

@@ -69,7 +69,9 @@ ir_expression::constant_expression_value()
} }
if (op[1] != NULL) if (op[1] != NULL)
assert(op[0]->type->base_type == op[1]->type->base_type); assert(op[0]->type->base_type == op[1]->type->base_type ||
this->operation == ir_binop_lshift ||
this->operation == ir_binop_rshift);
bool op0_scalar = op[0]->type->is_scalar(); bool op0_scalar = op[0]->type->is_scalar();
bool op1_scalar = op[1] != NULL && op[1]->type->is_scalar(); bool op1_scalar = op[1] != NULL && op[1]->type->is_scalar();