OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radeonsi: add decision code to select when to use CB_RESOLVE for performance

Browse Source 
The answer is "almost never".

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
This commit is contained in:
Marek Olšák
2024-04-16 15:18:08 -04:00
committed by Marge Bot
parent c5641387f3
commit 3424e16ece
1 changed files with 33 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/gallium/drivers/radeonsi/si_blit.c
View File

@@ -1116,6 +1116,7 @@ bool si_msaa_resolve_blit_via_CB(struct pipe_context *ctx, const struct pipe_bli
unsigned dst_width = u_minify(info->dst.resource->width0, info->dst.level); unsigned dst_width = u_minify(info->dst.resource->width0, info->dst.level);
unsigned dst_height = u_minify(info->dst.resource->height0, info->dst.level); unsigned dst_height = u_minify(info->dst.resource->height0, info->dst.level);
enum pipe_format format = info->src.format; enum pipe_format format = info->src.format;
unsigned num_channels = util_format_description(format)->nr_channels;
/* Check basic requirements for hw resolve. */ /* Check basic requirements for hw resolve. */
if (!(info->src.resource->nr_samples > 1 && info->dst.resource->nr_samples <= 1 && if (!(info->src.resource->nr_samples > 1 && info->dst.resource->nr_samples <= 1 &&
@@ -1123,6 +1124,38 @@ bool si_msaa_resolve_blit_via_CB(struct pipe_context *ctx, const struct pipe_bli
util_max_layer(info->src.resource, 0) == 0)) util_max_layer(info->src.resource, 0) == 0))
return false; return false;
/* Return if this is slower than alternatives. */
if (fail_if_slow) {
/* CB_RESOLVE is much slower without FMASK. */
if (sctx->screen->debug_flags & DBG(NO_FMASK))
return false;
/* Verified on: Tahiti, Hawaii, Tonga, Vega10, Navi10, Navi21 */
switch (sctx->gfx_level) {
case GFX6:
return false;
case GFX7:
if (src->surface.bpe != 16)
return false;
break;
case GFX8:
case GFX9:
case GFX10:
return false;
case GFX10_3:
if (!(src->surface.bpe == 8 && src->buffer.b.b.nr_samples == 8 && num_channels == 4) &&
!(src->surface.bpe == 16 && src->buffer.b.b.nr_samples == 4))
return false;
break;
default:
unreachable("unexpected gfx version");
}
}
/* Hardware MSAA resolve doesn't work if SPI format = NORM16_ABGR and /* Hardware MSAA resolve doesn't work if SPI format = NORM16_ABGR and
* the format is R16G16. Use R16A16, which does work. * the format is R16G16. Use R16A16, which does work.
*/ */