OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glsl: free uniform_map on failure path.

Browse Source 
If we fails in reserve_explicit_locations, we leak uniform_map.

Reported-by: coverity scanner.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Dave Airlie
2014-09-02 09:54:36 +10:00
parent 9f20503658
commit 2d5d1f5598
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/glsl/linker.cpp
View File

@@ -2439,11 +2439,13 @@ check_explicit_uniform_locations(struct gl_context *ctx,
ir_variable *var = node->as_variable(); ir_variable *var = node->as_variable();
if ((var && var->data.mode == ir_var_uniform) && if ((var && var->data.mode == ir_var_uniform) &&
var->data.explicit_location) { var->data.explicit_location) {
if (!reserve_explicit_locations(prog, uniform_map, var)) if (!reserve_explicit_locations(prog, uniform_map, var)) {
delete uniform_map;
return; return;
} }
} }
} }
}
delete uniform_map; delete uniform_map;
} }