st/va:Add support for indirect manner by returning VA_STATUS_ERROR_OPERATION_FAILED

Based on VA Spec,DeriveImage() returns VA_STATUS_ERROR_OPERATION_FAILED if driver
dont have support for internal surface formats.Currently vaDeriveImage()
failed for non-contiguous planes and operation failed error string is
required to support indirect manner i.e. vaCreateImage()+vaPutImage()
incase vaDeriveImage() failed with VA_STATUS_ERROR_OPERATION_FAILED.

This patch will notify to the client as operation failed with proper
error sting,so that client will fallback to vaCreateImage()+vaPutImage().

v2: updated commit message based on VA spec.

Signed-off-by: suresh guttula <suresh.guttula@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
This commit is contained in:
Guttula, Suresh
2019-02-11 06:12:52 -05:00
committed by Leo Liu
parent 114a899cc8
commit 2cf2a56739

View File

@@ -212,9 +212,12 @@ vlVaDeriveImage(VADriverContextP ctx, VASurfaceID surface, VAImage *image)
surf = handle_table_get(drv->htab, surface);
if (!surf || !surf->buffer || surf->buffer->interlaced)
if (!surf || !surf->buffer)
return VA_STATUS_ERROR_INVALID_SURFACE;
if (surf->buffer->interlaced)
return VA_STATUS_ERROR_OPERATION_FAILED;
surfaces = surf->buffer->get_surfaces(surf->buffer);
if (!surfaces || !surfaces[0]->texture)
return VA_STATUS_ERROR_ALLOCATION_FAILED;
@@ -261,7 +264,7 @@ vlVaDeriveImage(VADriverContextP ctx, VASurfaceID surface, VAImage *image)
default:
/* VaDeriveImage is designed for contiguous planes. */
FREE(img);
return VA_STATUS_ERROR_INVALID_IMAGE_FORMAT;
return VA_STATUS_ERROR_OPERATION_FAILED;
}
img_buf = CALLOC(1, sizeof(vlVaBuffer));